From: Tom Lane <tgl@sss.pgh.pa.us>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Jonathan S. Katz <jkatz@postgresql.org>
Cc: krking@zju.edu.cn
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17477: A crash bug in transformValuesClause()
Date: Mon, 09 May 2022 14:33:38 -0400
Message-ID: <3910641.1652121218@sss.pgh.pa.us> (raw)
In-Reply-To: <CAD21AoDuQYcLmmPGe8-0ZoU=2VgvYAh1godFwYoNbSXe6TP0Qg@mail.gmail.com>
References: <17477-0af3c6ac6b0a6ae0@postgresql.org>
<CAD21AoCF5EWSXUR6MOGUWeqqo5bGw=_4LHDbwhPjO4x+xQn9QA@mail.gmail.com>
<3809468.1652109938@sss.pgh.pa.us>
<6f7f0d34-0f58-41a9-98b5-bf86e1960165@postgresql.org>
<CAD21AoDuQYcLmmPGe8-0ZoU=2VgvYAh1godFwYoNbSXe6TP0Qg@mail.gmail.com>
Masahiko Sawada <sawada.mshk@gmail.com> writes:
> On Tue, May 10, 2022 at 2:20 AM Jonathan S. Katz <jkatz@postgresql.org> wrote:
>> Confirmed reproducing the crash and that this fixes it. I did a short
>> double-take on the error message:
>>
>> ERROR: subquery must return only one column
>>
>> but it is accurate, given this is what the subquery must do, and zero !=
>> one.
> Agreed. I've also confirmed that the patch fixes this issue and passed
> the regression tests.
Thanks for checking! I've pushed the fix now.
When we have a little more time, we might want to look into making
VALUES-with-no-columns be fully supported, that is not a syntax error.
That's not a crasher bug though, so I feel no desire to deal with
it under a release deadline.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, sawada.mshk@gmail.com, jkatz@postgresql.org, krking@zju.edu.cn, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17477: A crash bug in transformValuesClause()
In-Reply-To: <3910641.1652121218@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox