From: Tom Lane <tgl@sss.pgh.pa.us>
To: evsi@amazon.com
Cc: pgsql-bugs@lists.postgresql.org, Andres Freund <andres@anarazel.de>
Subject: Re: BUG #19368: f54af9f does not create the correct macro for autotools build
Date: Wed, 31 Dec 2025 10:59:32 -0500
Message-ID: <3917069.1767196772@sss.pgh.pa.us> (raw)
In-Reply-To: <19368-016d79a7f3a1c599@postgresql.org>
References: <19368-016d79a7f3a1c599@postgresql.org>
PG Bug reporting form <noreply@postgresql.org> writes:
> The commit f54af9f2679d added a macro HAVE_LIBURING_QUEUE_INIT_MEM that is
> checked to see if slowdown from memory mappings can be avoided when using
> io_uring.
> This HAVE_LIBURING_QUEUE_INIT_MEM is set by Meson build after checking
> liburing.
> However, the autotools build seems to set a different macro,
> HAVE_IO_URING_QUEUE_INIT_MEM, which is never used.
> This means when the server is built with autotools, the slowdown when using
> io_uring can never be avoided.
This is indeed busted, but I'd argue that the autoconf build has the
right macro name and meson and the C code are using the wrong one:
if cc.has_function('io_uring_queue_init_mem',
dependencies: liburing, args: test_c_args)
cdata.set('HAVE_LIBURING_QUEUE_INIT_MEM', 1)
endif
That's clearly not following the "HAVE_function" convention.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, evsi@amazon.com, andres@anarazel.de
Subject: Re: BUG #19368: f54af9f does not create the correct macro for autotools build
In-Reply-To: <3917069.1767196772@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox