pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16161: pg_ctl stop fails sometimes (on Windows)
Date: Sat, 21 Dec 2019 17:41:52 -0500
Message-ID: <4104.1576968112@sss.pgh.pa.us> (raw)
In-Reply-To: <5c7eaa87-8670-2008-3a15-337c133c12c2@gmail.com>
References: <4741.1576684991@sss.pgh.pa.us>
	<b2cc98b1-0ba0-1358-572f-8a1a01a3880e@gmail.com>
	<26441.1576706955@sss.pgh.pa.us>
	<20191219.103948.2182167132387989763.horikyota.ntt@gmail.com>
	<d32a75e6-ba99-c95c-e475-1887c009d395@gmail.com>
	<32374.1576770248@sss.pgh.pa.us>
	<5c7eaa87-8670-2008-3a15-337c133c12c2@gmail.com>

Alexander Lakhin <exclusion@gmail.com> writes:
> 19.12.2019 18:44, Tom Lane wrote:
>> Entirely-untested patch along this line attached.

> I have tested it with my demo restart test and it works. Yes, stat() is
> resulted in the CreateFile() call too, so it should fail the same way.

Since this patch seems to fix the problem, I went ahead and pushed it.
We can still consider whether it can be improved, but I was getting
antsy about leaving the buildfarm broken.

			regards, tom lane





view thread (29+ messages)

Message-ID: <4104.1576968112@sss.pgh.pa.us>
Permalink:  ../4104.1576968112@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/4104.1576968112@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, exclusion@gmail.com, horikyota.ntt@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16161: pg_ctl stop fails sometimes (on Windows)
  In-Reply-To: <4104.1576968112@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox