pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Takeshi Ideriha <iderihatakeshi@gmail.com>
To: alpkeles99@gmail.com
To: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19760: CLUSTER loses a row the transaction inserted and then updated in a rolled-back subtransaction
Date: Fri, 16 Oct 2026 11:55:27 +0900
Message-ID: <41175da6-293f-4b8f-ad18-3636f3d8a2f6@gmail.com> (raw)
In-Reply-To: <19760-8f9a0eba17bc8c92@postgresql.org>
References: <19760-8f9a0eba17bc8c92@postgresql.org>

Hi

Thank you for reporting this.

> 
> CLUSTER (and REPACK on master) silently drops a live row when the same
> transaction inserted the row and then updated it inside a subtransaction
> that was rolled back. No error is raised; the row is gone after COMMIT.
> 
>   CREATE TABLE t1(c0 int, c1 int);
>   CREATE INDEX t1_i0 ON t1 (c1);
>   BEGIN;
>   INSERT INTO t1 VALUES (1, 1);
>   SAVEPOINT s1; UPDATE t1 SET c0 = 2; ROLLBACK TO s1;
>   CLUSTER t1 USING t1_i0;
>   SELECT count(*) FROM t1;   -- 0, expected 1
>   COMMIT;
>   SELECT count(*) FROM t1;   -- 0, expected 1
> 
While I was reproducing the bug, I noticed that if we SELECT rows before
CLUSTER, the issue won't happen. This suggests that not setting hint bit
is very likely to be related to the issue.

----
BEGIN;
INSERT INTO t1 VALUES (1, 1);
SAVEPOINT s1;
UPDATE t1 SET c0 = 2;
ROLLBACK TO s1;

SELECT count(*) FROM t1; -- SELECT before CLUSTER

CLUSTER VERBOSE t1 USING t1_i0;
SELECT count(*) FROM t1;
---

-- RESULT --
 count
-------
     1
(1 row)

INFO:  repacking "public.t1" using index scan on "t1_i0"
INFO:  "public.t1": found 0 removable, 1 nonremovable row versions in 1
pages
DETAIL:  0 dead row versions cannot be removed yet.
CPU: user: 0.00 s, system: 0.00 s, elapsed: 0.00 s.
CLUSTER
 count
-------
     1
(1 row)

COMMIT
 count
-------
     1
(1 row)


> REL_18_STABLE 4d62ef92fda. CLUSTER VERBOSE reports a
> negative "dead row versions cannot be removed yet" count (-1 here).

The value is tups_recently_dead in heapam_relation_copy_for_cluster().
tups_recently_dead decreases only when rewrite_heap_dead_tuple()
returnes TRUE in rewriteheap.c. I guess there is something wrong with
visibility check invloving hint bits in rewriteheap.c. I'll look into
this further.

Regards,
Takeshi Ideriha






view thread (30+ messages)  latest in thread

Message-ID: <41175da6-293f-4b8f-ad18-3636f3d8a2f6@gmail.com>
Permalink:  ../41175da6-293f-4b8f-ad18-3636f3d8a2f6@gmail.com/
Also on:    postgresql.org/message-id/41175da6-293f-4b8f-ad18-3636f3d8a2f6@gmail.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: iderihatakeshi@gmail.com, alpkeles99@gmail.com
  Subject: Re: BUG #19760: CLUSTER loses a row the transaction inserted and then updated in a rolled-back subtransaction
  In-Reply-To: <41175da6-293f-4b8f-ad18-3636f3d8a2f6@gmail.com>
  References: <19760-8f9a0eba17bc8c92@postgresql.org> <41175da6-293f-4b8f-ad18-3636f3d8a2f6@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox