From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: Another FK violation when referencing a multi-level partitioned table
Date: Sun, 09 Feb 2020 12:48:49 -0500
Message-ID: <467.1581270529@sss.pgh.pa.us> (raw)
In-Reply-To: <20200207213051.GA32185@alvherre.pgsql>
References: <20200207213051.GA32185@alvherre.pgsql>
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> On 2020-Feb-06, Jehan-Guillaume de Rorthais wrote:
>> Please, find in attachment a proposal patch to fix this FK violation.
> You fix looks correct to me, so pushed. I took a minute to apply some
> minor corrections to the comments, too.
FWIW, I think the test query is too smart for its own good:
SELECT fk.fk_a, pk.a
FROM fkpart9.fk
LEFT JOIN fkpart9.pk ON fk.fk_a = pk.a
WHERE fk.fk_a=35;
The trouble with this is that the planner would be fully within its
rights to conclude that the FK constraint means a pk row must exist
for every fk row, and hence strength-reduce the left join to a
plain join. That would mask this bug, if it ever reappeared.
There's no such optimization today, but people have proposed patches
that do that or very similar things, so I have no confidence in the
long-term safety of this test case. I'd replace the above SELECT
with just
SELECT * FROM fkpart9.fk;
and maybe also similarly select all of fkpart9.pk, if you wanted
to verify that the right thing had happened on that side.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, jgdr@dalibo.com
Subject: Re: Another FK violation when referencing a multi-level partitioned table
In-Reply-To: <467.1581270529@sss.pgh.pa.us>
References: <20200207213051.GA32185@alvherre.pgsql> <467.1581270529@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox