pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: eli.mach@mailbox.org
To: pgsql-bugs@postgresql.org <pgsql-bugs@postgresql.org>
Subject: pretty_bool in pg_get_constraintdef has no effect since pg >= 9
Date: Tue, 25 Feb 2020 13:56:22 +0100 (CET)
Message-ID: <490036036.13996.1582635382921@office.mailbox.org> (raw)

Hello,

since postgres 9, `pg_get_constraintdef(cons.oid, pretty_bool)` does not work as expected. The result is always in "pretty"-format (with newlines), regardless of whether `pretty_bool` is true or false. Calling `pg_get_constraintdef(constraint_oid)` without `pretty_bool`, also returns "pretty"-format. 

Test with:

```
CREATE TABLE tbl (
   id int NOT NULL DEFAULT 0
  ,CHECK 
  (
    CASE
      WHEN id < 0 THEN false
      WHEN id >= 0 THEN true
    END
  )
);

SELECT cons.conname as name, pg_get_constraintdef(cons.oid, false) as src FROM pg_catalog.pg_constraint cons WHERE cons.conrelid IN (SELECT oid from pg_class WHERE relname='tbl') AND cons.contype = 'c';
```

Result on postgres 8:
```
CHECK (CASE WHEN (id < 0) THEN false WHEN (id >= 0) THEN true ELSE NULL::boolean END)
```

Result on postgres >= 9:
```
CHECK (                     
CASE                        
    WHEN (id < 0) THEN false
    WHEN (id >= 0) THEN true
    ELSE NULL::boolean      
END)
```

I'm migrating from postgres 8 to 11 and a sqlalchemy script throws a warning "SAWarning: Could not parse CHECK constraint text" because there a no newlines expected in `re.match(r"^CHECK *\((.+)\)( NOT VALID)?$", src)`.

Greetings,
elim.





view thread (3+ messages)  latest in thread

Message-ID: <490036036.13996.1582635382921@office.mailbox.org>
Permalink:  ../490036036.13996.1582635382921@office.mailbox.org/
Also on:    postgresql.org/message-id/490036036.13996.1582635382921@office.mailbox.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: eli.mach@mailbox.org
  Subject: Re: pretty_bool in pg_get_constraintdef has no effect since pg >= 9
  In-Reply-To: <490036036.13996.1582635382921@office.mailbox.org>
  References: <490036036.13996.1582635382921@office.mailbox.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox