pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Alexander Lakhin <exclusion@gmail.com>
To: Heikki Linnakangas <hlinnaka@iki.fi>
To: Jeff Janes <jeff.janes@gmail.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: kunert@cms.hu-berlin.de, pgsql-bugs <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #16162: create index using gist_trgm_ops leads to panic
Date: Mon, 16 Dec 2019 22:00:00 +0300
Message-ID: <4dc09c87-c10d-801e-830b-ae82de53a4a0@gmail.com> (raw)
In-Reply-To: <7b7e1807-7393-ad90-7492-7837d3956308@iki.fi>
References: <16162-45d21b7b6c1a3105@postgresql.org>
	<20191212125023.vpk6zbbeldzmyerc@development>
	<26141.1576158262@sss.pgh.pa.us>
	<CAMkU=1ymVJWS_u6ndDarWfaOQz44Td2DWgpA_3t4+OV4xsV3WQ@mail.gmail.com>
	<20191213001618.jqeousv77xnlds7x@development>
	<2ca3ae2a-e770-012b-3da1-169a3818927a@iki.fi>
	<d869f537-abe4-d2ea-0510-38cd053f5152@gmail.com>
	<CAMkU=1yUAK8Uh3A0A3cP4xQx4zAZ7KVAJ66aMmbh_BbiXnba6w@mail.gmail.com>
	<7b7e1807-7393-ad90-7492-7837d3956308@iki.fi>

Hello Heikki,
16.12.2019 15:02, Heikki Linnakangas wrote:
>
> I added the "stack-downlinkoffnum = InvalidOffsetNumber" to the first
> call on Friday. But the second call needs the same treatment, because
> it's possible that we reuse the same stack on a later call to
> gistfinishsplit(), if a grandchild page is split twice, for the same
> leaf insert. I feel pretty dumb, because I looked at that second call
> on Friday too, thinking if it also needs to reset 'downlinkoffnum',
> but somehow I concluded it does not. Clearly it does, as this test
> case demonstrates.
>
> Fix committed. Thanks again for the report!
I can confirm that now the issue is gone.
Thank you!

Best regards,
Alexander





view thread (13+ messages)

Message-ID: <4dc09c87-c10d-801e-830b-ae82de53a4a0@gmail.com>
Permalink:  ../4dc09c87-c10d-801e-830b-ae82de53a4a0@gmail.com/
Also on:    postgresql.org/message-id/4dc09c87-c10d-801e-830b-ae82de53a4a0@gmail.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: exclusion@gmail.com, hlinnaka@iki.fi, jeff.janes@gmail.com, tomas.vondra@2ndquadrant.com, tgl@sss.pgh.pa.us, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16162: create index using gist_trgm_ops leads to panic
  In-Reply-To: <4dc09c87-c10d-801e-830b-ae82de53a4a0@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox