pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18769: ldapscheme is not displayed in pg_hba_file_rules
Date: Thu, 09 Jan 2025 10:54:15 +0100
Message-ID: <513a15b5ff69d6023b57e78bbcf5a7c17180cedc.camel@cybertec.at> (raw)
In-Reply-To: <18769-dd8610cbc0405172@postgresql.org>
References: <18769-dd8610cbc0405172@postgresql.org>

On Thu, 2025-01-09 at 09:45 +0000, PG Bug reporting form wrote:
> For whatever reason, the "ldapscheme" option was forgotten in the function
> pg_hba_file_rules().

Here is a patch to fix the omission.

Yours,
Laurenz Albe

Attachments:

  [text/x-patch] v1-0001-Add-ldapscheme-to-pg_hba_file_rules.patch (1.0K, ../513a15b5ff69d6023b57e78bbcf5a7c17180cedc.camel@cybertec.at/2-v1-0001-Add-ldapscheme-to-pg_hba_file_rules.patch)
  download | inline diff:
From b976eaf4cbbef79b43fb541b33982d9d742c7f75 Mon Sep 17 00:00:00 2001
From: Laurenz Albe <laurenz.albe@cybertec.at>
Date: Thu, 9 Jan 2025 10:41:34 +0100
Subject: [PATCH v1] Add ldapscheme to pg_hba_file_rules

That option was forgotten in the pg_hba_file_rules() function.
This fixes bug #18769.  Backpatch all the way.

Author: Laurenz Albe
Discussion: https://postgr.es/m/18769-dd8610cbc0405172@postgresql.org
---
 src/backend/utils/adt/hbafuncs.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/backend/utils/adt/hbafuncs.c b/src/backend/utils/adt/hbafuncs.c
index beaae88e541..43cef2572f8 100644
--- a/src/backend/utils/adt/hbafuncs.c
+++ b/src/backend/utils/adt/hbafuncs.c
@@ -89,6 +89,10 @@ get_hba_options(HbaLine *hba)
 			options[noptions++] =
 				CStringGetTextDatum(psprintf("ldapport=%d", hba->ldapport));
 
+		if (hba->ldapscheme)
+			options[noptions++] =
+				CStringGetTextDatum(psprintf("ldapscheme=%s", hba->ldapscheme));
+
 		if (hba->ldaptls)
 			options[noptions++] =
 				CStringGetTextDatum("ldaptls=true");
-- 
2.47.1



view thread (8+ messages)  latest in thread

Message-ID: <513a15b5ff69d6023b57e78bbcf5a7c17180cedc.camel@cybertec.at>
Permalink:  ../513a15b5ff69d6023b57e78bbcf5a7c17180cedc.camel@cybertec.at/
Also on:    postgresql.org/message-id/513a15b5ff69d6023b57e78bbcf5a7c17180cedc.camel@cybertec.at

 ·  · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: laurenz.albe@cybertec.at, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #18769: ldapscheme is not displayed in pg_hba_file_rules
  In-Reply-To: <513a15b5ff69d6023b57e78bbcf5a7c17180cedc.camel@cybertec.at>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox