From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: gomer94@yandex.ru
Cc: pgsql-bugs@postgresql.org
Subject: Re: BUG #14867: Cascade drop type error
Date: Mon, 23 Oct 2017 12:33:52 -0400
Message-ID: <5379.1508776432@sss.pgh.pa.us> (raw)
In-Reply-To: <20171023161726.5hr6rs56hxn67zz2@alap3.anarazel.de>
References: <20171023150118.1477.19174@wrigleys.postgresql.org>
<4421.1508774964@sss.pgh.pa.us>
<20171023161726.5hr6rs56hxn67zz2@alap3.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-bugs>
Andres Freund <andres@anarazel.de> writes:
> On 2017-10-23 12:09:24 -0400, Tom Lane wrote:
>> Cute. Type my_type isn't exposed as a dependency of the view,
>> because it's only referenced internally in the expression tree
>> not as a result column type. We can fix that easily enough by
>> teaching dependency.c to log the result type of a FieldSelect
>> as a dependency.
> That does remind me of patch 0001 in
> http://archives.postgresql.org/message-id/20170314224706.nxvtapenky6eom3z%40alap3.anarazel.de
It is in the same part of the code, but seems directed at a different
goal (which I disapproved of, IIRC). But we definitely need the
principle that any type OID appearing in an expression tree needs to
be logged, except in cases where there's necessarily an indirect
dependency (eg, a function or operator's result type doesn't need to
be logged separately).
regards, tom lane
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, gomer94@yandex.ru
Subject: Re: BUG #14867: Cascade drop type error
In-Reply-To: <5379.1508776432@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox