pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Jeff Davis <pgsql@j-davis.com>
To: vignesh C <vignesh21@gmail.com>
To: Peter Smith <smithpb2250@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: pgsql-bugs@postgresql.org
Subject: Re: [16+] subscription can end up in inconsistent state
Date: Fri, 12 Jan 2024 13:55:28 -0800
Message-ID: <5438ebe33bce797e5ffe24eaca81f1d130af9617.camel@j-davis.com> (raw)
In-Reply-To: <CALDaNm2L9uDP3HsgSiBUGQWQAxVviA_BdcTHRUUiXTDJMpKD1Q@mail.gmail.com>
References: <e5892973ae2a80a1a3e0266806640dae3c428100.camel@j-davis.com>
	<CAA4eK1LJEMfdxpV7xDhR3qOFoSt3LuKbbu5kRMBfYJ2imT8Few@mail.gmail.com>
	<5dff4caf26f45ce224a33a5e18e110b93a351b2f.camel@j-davis.com>
	<CALDaNm0fJ8dibhG-2sVKJaLP8pz-2T1o9epPvcdpb9FHyhn3gg@mail.gmail.com>
	<CA+TgmoYy7Z=x+yaK1ugDqrUuMUNWcJkZdVF4E_+3L0tcmopcTA@mail.gmail.com>
	<CALDaNm06nUm0URSYiduxi3VqdWZ=Swv4T8x0exHTr-aHMb4e+w@mail.gmail.com>
	<CALDaNm1A50g3x+hiRT8UjPK3oETFtabTm=W-AhruHeNKh0Uz=Q@mail.gmail.com>
	<CAHut+PsQBUGhPVTYRpGE8wogS5xbSouecGSCDdha-Bd-PP22ag@mail.gmail.com>
	<CALDaNm3jbhVzT5XbBrU1=JfospGKz65a9mxJccR5O=c3Z13qjA@mail.gmail.com>
	<CAHut+Pteo8qtXwEGNy42s2S-O=CU2wSZAicYd1bKn5TOTJyKWg@mail.gmail.com>
	<CALDaNm2L9uDP3HsgSiBUGQWQAxVviA_BdcTHRUUiXTDJMpKD1Q@mail.gmail.com>

On Mon, 2023-11-27 at 10:26 +0530, vignesh C wrote:
> The patch was not applying on HEAD because of recent commits, the
> attached v6 version patch is rebased on top of HEAD.

Thank you, committed with minor modifications.

I decided to do:

   libpqrcv_check_conninfo(conninfo, must_use_password);

rather than:

   if (must_use_password)                                             
      libpqrcv_check_conninfo(conninfo, true);

because if there's some parsing error then we wouldn't like it to be
conditional on must_use_password. Of course, there should not be any
parsing error because it was already validated at DDL time, but in case
there's another way to get into an inconsistent state, we might as well
re-validate here.

Regards,
	Jeff Davis






view thread (25+ messages)  latest in thread

Message-ID: <5438ebe33bce797e5ffe24eaca81f1d130af9617.camel@j-davis.com>
Permalink:  ../5438ebe33bce797e5ffe24eaca81f1d130af9617.camel@j-davis.com/
Also on:    postgresql.org/message-id/5438ebe33bce797e5ffe24eaca81f1d130af9617.camel@j-davis.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: pgsql@j-davis.com, vignesh21@gmail.com, smithpb2250@gmail.com, robertmhaas@gmail.com, amit.kapila16@gmail.com
  Subject: Re: [16+] subscription can end up in inconsistent state
  In-Reply-To: <5438ebe33bce797e5ffe24eaca81f1d130af9617.camel@j-davis.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox