pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Sudheer H R <sudheer.hr@tekenlight.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: Found a buffer-overflow defect in asynchronous database connection API PQconnectPoll
Date: Thu, 24 Jun 2021 07:23:37 +0530
Message-ID: <54573F29-636F-4889-9673-7DE8C6645629@tekenlight.com> (raw)
In-Reply-To: <2338837.1624471430@sss.pgh.pa.us>
References: <5372B6D4-8276-42C0-B8FB-BD0918826FC3@tekenlight.com>
	<2080223.1624454678@sss.pgh.pa.us>
	<96EB194C-6EF0-4F79-A855-F28CD7DE4F95@tekenlight.com>
	<205CACC4-0EBF-4672-95F4-2E1949371FE7@tekenlight.com>
	<2081383.1624455807@sss.pgh.pa.us>
	<FD6FD3A2-4EAB-487E-9ABD-A38CE36DCAC2@tekenlight.com>
	<2081779.1624456225@sss.pgh.pa.us>
	<0988202C-570F-4919-B14E-135CCFCDB1C6@tekenlight.com>
	<B5E2F345-F186-41B3-B341-9F31429A5FBC@tekenlight.com>
	<2249065.1624464160@sss.pgh.pa.us>
	<2338837.1624471430@sss.pgh.pa.us>

Thanks a lot

> On 23-Jun-2021, at 11:33 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> I wrote:
>> Hmph.  I can't reproduce this on RHEL8: so far as I can tell, the string
>> is physically null-terminated, and clang's address sanitizer doesn't
>> complain either.  Still, given the vagueness of the spec for
>> gss_display_status, it seems wise to not assume that every GSS
>> implementation acts the same.
> 
> I've committed fixes to make our code rely on the returned length
> field instead.  Hopefully that won't expose any new bugs in other
> GSS implementations :-(
> 
> 			regards, tom lane






view thread (13+ messages)

Message-ID: <54573F29-636F-4889-9673-7DE8C6645629@tekenlight.com>
Permalink:  ../54573F29-636F-4889-9673-7DE8C6645629@tekenlight.com/
Also on:    postgresql.org/message-id/54573F29-636F-4889-9673-7DE8C6645629@tekenlight.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: sudheer.hr@tekenlight.com, tgl@sss.pgh.pa.us
  Subject: Re: Found a buffer-overflow defect in asynchronous database connection API PQconnectPoll
  In-Reply-To: <54573F29-636F-4889-9673-7DE8C6645629@tekenlight.com>
  References: <5372B6D4-8276-42C0-B8FB-BD0918826FC3@tekenlight.com> <2080223.1624454678@sss.pgh.pa.us> <96EB194C-6EF0-4F79-A855-F28CD7DE4F95@tekenlight.com> <205CACC4-0EBF-4672-95F4-2E1949371FE7@tekenlight.com> <2081383.1624455807@sss.pgh.pa.us> <FD6FD3A2-4EAB-487E-9ABD-A38CE36DCAC2@tekenlight.com> <2081779.1624456225@sss.pgh.pa.us> <0988202C-570F-4919-B14E-135CCFCDB1C6@tekenlight.com> <B5E2F345-F186-41B3-B341-9F31429A5FBC@tekenlight.com> <2249065.1624464160@sss.pgh.pa.us> <2338837.1624471430@sss.pgh.pa.us> <54573F29-636F-4889-9673-7DE8C6645629@tekenlight.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox