pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: James Inform <james.inform@pharmapp.de>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Cc: Euler Taveira <euler@eulerto.com>
Subject: Re: BUG #17584: SQL crashes PostgreSQL when using ICU collation
Date: Sat, 13 Aug 2022 23:21:04 -0400
Message-ID: <555147.1660447264@sss.pgh.pa.us> (raw)
In-Reply-To: <CAH2-Wzk11wvwjhrbje4DDyXydy5pGACb4wNCHCXiuij0Y10h+Q@mail.gmail.com>
References: <17584-95c79b4a7d771f44@postgresql.org>
	<f6d74de8-df28-4ef7-8d9e-10f2ab77ea8e@www.fastmail.com>
	<a9851f48-b281-8313-52f4-59ece14adb86@pharmapp.de>
	<465044.1660428315@sss.pgh.pa.us>
	<92087cd5-5410-a4e9-41fe-4ff310439190@pharmapp.de>
	<541938.1660437017@sss.pgh.pa.us>
	<CAH2-Wzk11wvwjhrbje4DDyXydy5pGACb4wNCHCXiuij0Y10h+Q@mail.gmail.com>

Peter Geoghegan <pg@bowt.ie> writes:
> I think that repalloc might even be mandatory. These buffers are used
> as caches that allow us to avoid repeat strxfrm()/strcoll() calls,
> which is quite a useful optimization. But we're not accounting for
> that here -- we're not invalidating the cache. We wouldn't have to
> bother with that if we just used repalloc().

Hmm, but if we're enlarging the buffer, doesn't that imply
a new input value?  Seems like invalidation must occur anyway.

			regards, tom lane





view thread (14+ messages)  latest in thread

Message-ID: <555147.1660447264@sss.pgh.pa.us>
Permalink:  ../555147.1660447264@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/555147.1660447264@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pg@bowt.ie, james.inform@pharmapp.de, pgsql-bugs@lists.postgresql.org, euler@eulerto.com
  Subject: Re: BUG #17584: SQL crashes PostgreSQL when using ICU collation
  In-Reply-To: <555147.1660447264@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox