pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Klaudie Willis <Klaudie.Willis@protonmail.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: When Update balloons memory
Date: Tue, 14 Dec 2021 18:28:52 -0500
Message-ID: <562709.1639524532@sss.pgh.pa.us> (raw)
In-Reply-To: <CAH2-Wzm8asKGAMy=bse5nTHq6CPZDdw5gHFH3WP8-Fdm25foQw@mail.gmail.com>
References: <wJYzIcLjhFnsbCK8sy4lZZAojx7m04FwjsGF4WbrKj0gj2wLpaycQSEN1mtBUlhSAQGRvEdxZTwWRNV39UevSNWg8-h-tvWAL61pV4IuhW4=@protonmail.com>
	<3484560.1638889073@sss.pgh.pa.us>
	<YAjwxLJ1p4do7V4OkzpgwXrfV-fywioBsfvFaHnuY1Hbe-NjM0tsaCpJ_-KXwvFKF2YsQzQLCnFFFlMnyzd6TJ9UcXnQpcZfdZ1ZDcCqXIE=@protonmail.com>
	<189763.1639437451@sss.pgh.pa.us>
	<lviv_r7tA44gnx3rRU8VYdseWJLx-AzQCbsgdyz2-1Lse9ZmqDeLnzfDkBTut26kxlPZ8FX36TiKmCtXi5gAfhI-JVu-2n8fu7Dcta0Y3Ek=@protonmail.com>
	<261065.1639497535@sss.pgh.pa.us>
	<CAH2-Wzm54LA8EeOf6-cFZCHwigZ0YgQVgcmuyFr=b8w2pzQgzA@mail.gmail.com>
	<377324.1639510427@sss.pgh.pa.us>
	<CAH2-Wzm8asKGAMy=bse5nTHq6CPZDdw5gHFH3WP8-Fdm25foQw@mail.gmail.com>

Peter Geoghegan <pg@bowt.ie> writes:
> On Tue, Dec 14, 2021 at 11:33 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> And, not to be too picky, but does this cope with the case where
>> an indexed column is changed by a BEFORE trigger, not by the
>> query proper?

> No. It's much better to err in the direction of giving the hint,
> rather than not giving the hint. In order for us to make the category
> of error that seems like it might actually be a problem (not giving
> the hint when we should), the BEFORE trigger would have to "undo" an
> explicit change to an updated column.

Uh ... it seems that you are writing as though "giving the hint"
means saying that the column value changed.  That seems quite
confusingly backwards to me, as that is/ought to be the expected
assumption.  Maybe you should invert the flag state while you
are at it.

			regards, tom lane





view thread (22+ messages)  latest in thread

Message-ID: <562709.1639524532@sss.pgh.pa.us>
Permalink:  ../562709.1639524532@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/562709.1639524532@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pg@bowt.ie, Klaudie.Willis@protonmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: When Update balloons memory
  In-Reply-To: <562709.1639524532@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox