pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Langote <amitlangote09@gmail.com>
Cc: fedor_erastov@mail.ru, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Cc: Andres Freund <andres@anarazel.de>
Cc: Andrew Dunstan <andrew@dunslane.net>
Subject: Re: BUG #16644: null value for defaults in OLD variable for trigger
Date: Sun, 25 Oct 2020 13:59:30 -0400
Message-ID: <568704.1603648770@sss.pgh.pa.us> (raw)
In-Reply-To: <207142.1603468329@sss.pgh.pa.us>
References: <16644-5da7ef98a7ac4545@postgresql.org>
	<802555.1601432494@sss.pgh.pa.us>
	<CA+HiwqH7ys=WmnbGm+wgQwt0WzvQ-R-Qn4vdE01Q_QsX7cyFsw@mail.gmail.com>
	<207142.1603468329@sss.pgh.pa.us>

I wrote:
> Amit Langote <amitlangote09@gmail.com> writes:
>> Maybe something like the attached?

> Probably needs some attention to memory management (e.g.,
> should_free_trig) but I'm okay with doing this as a short-term
> fix.

I fixed the should_free business, and spent a fair amount of time
convincing myself that no other code paths in trigger.c need this,
and pushed it.

			regards, tom lane





view thread (10+ messages)  latest in thread

Message-ID: <568704.1603648770@sss.pgh.pa.us>
Permalink:  ../568704.1603648770@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/568704.1603648770@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, amitlangote09@gmail.com, pgsql-bugs@lists.postgresql.org, andres@anarazel.de, andrew@dunslane.net
  Subject: Re: BUG #16644: null value for defaults in OLD variable for trigger
  In-Reply-To: <568704.1603648770@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox