pg.ddx.io pgsql-bugs@postgresql.org mailing list archive help / color / mirror / Atom feed From: David Steele <david@pgmasters.net>
To: Michael Paquier <michael.paquier@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Jeff Janes <jeff.janes@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby
Date: Mon, 14 Mar 2016 13:46:40 -0400
Message-ID: <56E6F900.1090809@pgmasters.net> (raw )
In-Reply-To: <CAB7nPqQAaB0v25tt4SJ_mGc3aHfZrionEG4E5cceGVZc0B6QyA@mail.gmail.com >
References: <CAA4eK1LbbWPiwzP3NMEVijFb_PymQB6GyTDTgSyaDOpHZqm69g@mail.gmail.com >
<CAA4eK1+s2wt07So8B-FiHqjjJkYxvgx8LtoQX-kL+dOw3_hj5A@mail.gmail.com >
<20160204131003.h7obwkeaellkcewb@alap3.anarazel.de >
<CAB7nPqQYYesPsmGfeWzuZ9yPQgvJ9KkhzXmoV9O+FYLAq1iNKA@mail.gmail.com >
<CAB7nPqT_AUQS=41n6yy_=w2Txt=LBvq+hZr+2jD4=oevHe7e6Q@mail.gmail.com >
<20160206174930.GA21471@awork2.anarazel.de >
<CAB7nPqQ-S=femg=R3xKAC=59QEqC1MdmTphVydMKWCQtn8dL3Q@mail.gmail.com >
<20160208091852.6xikp5lxkqitdon3@alap3.anarazel.de >
<CA+TgmoYgLeetj=pQQ1oMj5KyqD4-pf5tcPbiSjQSooyw2Qa=ZQ@mail.gmail.com >
<20160212175635.6zledt7gvww24wfj@alap3.anarazel.de >
<CA+TgmoZ3bWMwdh+xsduXgYPTuJ8u8d-ZecovUWJdjc-Jx-0=mA@mail.gmail.com >
<CAB7nPqSxxo77VfUoABJ6oXtDsgkKuXwpTn5FTsuoe_L=sej-Ww@mail.gmail.com >
<CAB7nPqTrLKHpnzWADGdk7qzFj4ucsAN8M030jmd9y1EorEZPkw@mail.gmail.com >
<CA+TgmobL1bT1snn3nMEZBRANfO-R4Vc55b14thRgwF4C+pCKXw@mail.gmail.com >
<CAB7nPqQAaB0v25tt4SJ_mGc3aHfZrionEG4E5cceGVZc0B6QyA@mail.gmail.com >
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 2/24/16 12:40 AM, Michael Paquier wrote:
> This has the merit to be clear, thanks for the input. Whatever the
> approach taken at the end we have two candidates:
> - Extend XLogInsert() with an extra argument for flags (Andres)
> - Introduce XLogInsertExtended with this extra argument and let
> XLogInsert() in peace (Robert and I).
> Actually, I lied, there was still something I could do for this
> thread: attached are two patches implementing both approaches as
> respectively a-1 and a-2. Patch b is the set of logs I used for the
> tests to show with a low checkpoint_timeout that checkpoints are
> getting correctly skipped on an idle system.
Unfortunately neither A nor B apply anymore.
However, since the patches can still be read through I wonder if Robert
or Andres would care to opine on whether A or B is better now that they
can see the full implementation?
For my 2c I'm happy with XLogInsertExtended() since it seems to be a
rare use case where flags are required. This can always be refactored
in the future if/when the use of flags spreads.
I think it would be good to make a decision on this before asking
Michael to rebase.
Thanks,
--
-David
david@pgmasters.net
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
view thread (87+ messages) latest in thread
Message-ID: <56E6F900.1090809@pgmasters.net>
Permalink: ../56E6F900.1090809@pgmasters.net/
Also on: postgresql.org/message-id/56E6F900.1090809@pgmasters.net
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: david@pgmasters.net, michael.paquier@gmail.com, robertmhaas@gmail.com, andres@anarazel.de, amit.kapila16@gmail.com, jeff.janes@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby
In-Reply-To: <56E6F900.1090809@pgmasters.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox