From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: zoulx1982@163.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16931: source code problem about commit_ts
Date: Thu, 25 Mar 2021 11:59:49 +0900
Message-ID: <576efafd-30ad-68bb-563c-a5f230cbf588@oss.nttdata.com> (raw)
In-Reply-To: <20210324163931.GA24841@alvherre.pgsql>
References: <20210324163931.GA24841@alvherre.pgsql>
On 2021/03/25 1:39, Alvaro Herrera wrote:
> On 2021-Mar-24, Fujii Masao wrote:
>
>> On 2021/03/24 18:05, Alvaro Herrera wrote:
>>> Yeah, it seems like a bug. With your patch, the write_xlog=true path
>>> becomes unused, and thus the whole COMMIT_TS_SETTS record, so we could
>>> remove those things in branch master. The timestamp is acquired from
>>> the COMMIT record.
>>
>> I agree to remove COMMIT_TS_SETTS record from the master branch
>> if there are no users or extensions of it. Patch attached.
>
> Looks good in a quick skim. Let's get this pushed quickly; if anything
> exists out there that is calling that code, it'd be good to know sooner
> rather than later. However, my feeling is that no such caller exists,
> because they would have told us about this problem already.
Agreed. I will commit the patch in the master.
> Are you bumping WAL page magic? It'd be logical to do so, but on the
> other hand if no code exists that is capable of emitting that record,
> then it'd be pointless.
Yes, I'm thinking to bump WAL page magic because it seems a bit safer.
>> Anyway, at first, what about applying the bugfix patch I posted upthread
>> to all supported branches?
>
> Yeah, let's do that.
Pushed. Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: masao.fujii@oss.nttdata.com, alvherre@alvh.no-ip.org, zoulx1982@163.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16931: source code problem about commit_ts
In-Reply-To: <576efafd-30ad-68bb-563c-a5f230cbf588@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox