From: Tom Lane <tgl@sss.pgh.pa.us>
To: Neil Chen <carpenter.nail.cz@gmail.com>
Cc: contact@yorhel.nl
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16846: "retrieved too many tuples in a bounded sort"
Date: Thu, 04 Feb 2021 19:17:12 -0500
Message-ID: <6068.1612484232@sss.pgh.pa.us> (raw)
In-Reply-To: <CAA3qoJ=OokS7T9K81dHSK85gKx+CbmuArf9uhrqJxT1qFjkz2Q@mail.gmail.com>
References: <16846-ae49f51ac379a4cb@postgresql.org>
<CAA3qoJ=OokS7T9K81dHSK85gKx+CbmuArf9uhrqJxT1qFjkz2Q@mail.gmail.com>
Neil Chen <carpenter.nail.cz@gmail.com> writes:
> Bugs can be fixed with this additional patch, and I have also done tests
> and regression tests. I hope hackers can help me to see if I think wrong or
> miss anything, and I'm sorry that English is not my first language. I hope
> you can tell me if you have any better opinions on the expression of notes,
> thanks.
Hi Neil,
I poked at this until I found a small modification of the existing
regression tests that would reach the problematic path with lastTuple
true. That confirmed that there's a problem, because it gave a flat-out
wrong answer. I'm not really familiar enough with this code to be sure
if this is a complete fix, but it fixes the cases we have and it doesn't
break anything else in our regression tests. So, in view of the fact
that we have 13.2 release deadline on Monday, I went ahead and pushed it.
(I did rewrite your comment.)
Thanks for the patch!
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, carpenter.nail.cz@gmail.com, contact@yorhel.nl, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16846: "retrieved too many tuples in a bounded sort"
In-Reply-To: <6068.1612484232@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox