pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Thomas Butz <tbutz@optitool.de>
Cc: pgsql-bugs <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #16241: Degraded hash join performance
Date: Tue, 04 Feb 2020 11:00:29 -0500
Message-ID: <6089.1580832029@sss.pgh.pa.us> (raw)
In-Reply-To: <20200204134408.oing4ypvshgr5ykx@alap3.anarazel.de>
References: <20200204134408.oing4ypvshgr5ykx@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> Interesting! The no-children one clearly shows that a lot of the the
> time is spent evaluating regular expressions (there's other regex
> functions in the profile too):
>     23.36%  postgres  postgres            [.] subcolor

Huh ...

> I'm not aware of any relevant regular expression evaluation changes
> between 11 and 12. Tom, does this trigger anything?

(1) Nope, I'm not either; the last non-back-patched change in that
code was c54159d44 in v10.

(2) subcolor() is part of regex compilation, not execution, which makes
one wonder why it's showing up at all.  Maybe the regex cache in
adt/regexp.c is overflowing and preventing useful caching?  But
that didn't change in v12 either.  Are these test cases really
100% equivalent?  I'm wondering if there are a few more "hot"
regex patterns in the v12 data ...

(3) Where the heck is the regex use coming from at all?  I don't
see any regex operators in the plan.  Maybe it's inside the
plpgsql function?

			regards, tom lane





view thread (9+ messages)  latest in thread

Message-ID: <6089.1580832029@sss.pgh.pa.us>
Permalink:  ../6089.1580832029@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/6089.1580832029@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, tbutz@optitool.de
  Subject: Re: BUG #16241: Degraded hash join performance
  In-Reply-To: <6089.1580832029@sss.pgh.pa.us>
  References: <20200204134408.oing4ypvshgr5ykx@alap3.anarazel.de> <6089.1580832029@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox