From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: fcs1@poczta.onet.pl
Cc: pgsql-bugs@postgresql.org
Subject: Re: BUG #14738: ALTER SERVER for foregin servers not working
Date: Tue, 11 Jul 2017 15:39:14 -0400
Message-ID: <6234.1499801954@sss.pgh.pa.us> (raw)
In-Reply-To: <c79504e3-b83b-2161-9d3a-5f34e4885072@lab.ntt.co.jp>
References: <20170710113917.7727.10247@wrigleys.postgresql.org>
<1838.1499703533@sss.pgh.pa.us>
<20170711.102840.130532041.horiguchi.kyotaro@lab.ntt.co.jp>
<c79504e3-b83b-2161-9d3a-5f34e4885072@lab.ntt.co.jp>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-bugs>
Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> writes:
> Horiguchi-san,
> On 2017/07/11 10:28, Kyotaro HORIGUCHI wrote:
>> I faintly recall such discussion was held aroud that time and
>> maybe we concluded that we don't do that but I haven't find such
>> a thread in pgsql-hackers..
> I mentioned it in my reply. Here again:
> https://www.postgresql.org/message-id/20160405.184408.166437663.horiguchi.kyotaro%40lab.ntt.co.jp
The followup discussion noted that that approach was no good because it
would only close connections in the same session that had done the ALTER
SERVER. I think the basic idea of marking postgres_fdw connections as
needing to be remade when next possible is OK, but we have to drive it
off catcache invalidation events, the same as we did in c52d37c8b. An
advantage of that way is we don't need any new hooks in the core code.
Kyotaro-san, are you planning to update your old patch?
regards, tom lane
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, Langote_Amit_f8@lab.ntt.co.jp, horiguchi.kyotaro@lab.ntt.co.jp, fcs1@poczta.onet.pl
Subject: Re: BUG #14738: ALTER SERVER for foregin servers not working
In-Reply-To: <6234.1499801954@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox