From: David Steele <david@pgmasters.net>
To: Michael Paquier <michael@paquier.xyz>
To: Roman Peshkurov <roman.peshkurov@gmail.com>
Cc: pgsql-bugs@postgresql.org
Subject: Re: Bug with memory leak on cert validation in libpq
Date: Tue, 21 Apr 2020 10:46:34 -0400
Message-ID: <62894bf0-4bde-1d5b-75a2-20d44fc47fe6@pgmasters.net> (raw)
In-Reply-To: <20200421044235.GA6436@paquier.xyz>
References: <CALLDf-pZ-E3mjxd5=bnHsDu9zHEOnpgPgdnO84E2RuwMCjjyPw@mail.gmail.com>
<20200421044235.GA6436@paquier.xyz>
On 4/21/20 12:42 AM, Michael Paquier wrote:
> On Mon, Apr 20, 2020 at 08:40:06PM +0300, Roman Peshkurov wrote:
>> The problem is incorrect usage of openssl stack "destructor". We noticed it
>> on a graphs for the few months. It looked lika an increasing line of res
>> memory usage.
>
> And finally, this needs to be backpatched all the way down to 9.5, so
> I'll take care of it if there are no objections.
+1. We have similar code in pgBackRest and I can see the leak there as
well when I adjust our Valgrind supressions a bit.
I also reviewed the OpenSSL code and agree this is the right fix.
Regards,
--
-David
david@pgmasters.net
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: david@pgmasters.net, michael@paquier.xyz, roman.peshkurov@gmail.com
Subject: Re: Bug with memory leak on cert validation in libpq
In-Reply-To: <62894bf0-4bde-1d5b-75a2-20d44fc47fe6@pgmasters.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox