From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Jacob Champion <jchampion@timescale.com>
Cc: heath.lord@crunchydata.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17625: In PG15 PQsslAttribute returns different values than PG14 when SSL is not in use for the connection
Date: Fri, 30 Sep 2022 10:29:47 -0400
Message-ID: <640451.1664548187@sss.pgh.pa.us> (raw)
In-Reply-To: <5DD276A1-87D1-41D3-A9F1-4C0B6F5DAD48@yesql.se>
References: <17625-fc47c78b7d71b534@postgresql.org>
<346263.1664480998@sss.pgh.pa.us>
<360379.1664482591@sss.pgh.pa.us>
<CAAWbhmhYNOubS2qTx3rG8V2STZ9F0SrtRBuPJimCwRYAQ6r3BQ@mail.gmail.com>
<395956.1664484332@sss.pgh.pa.us>
<398499.1664485687@sss.pgh.pa.us>
<8F5DD45F-8A0D-4CBE-93B9-844C55886B85@yesql.se>
<467714.1664488691@sss.pgh.pa.us>
<5DD276A1-87D1-41D3-A9F1-4C0B6F5DAD48@yesql.se>
Daniel Gustafsson <daniel@yesql.se> writes:
> On 29 Sep 2022, at 23:58, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> - Returns an array of SSL attribute names available.
>> + Returns an array of SSL attribute names that can be used
>> + in <function>PQsslAttribute()</function>.
> Maybe hairsplitting, but should we note that it can be used in PQsslAttribute()
> for the conn which was passed as param to PQsslAttributeNames()? In a (still
> hypothetical) multi-library case there is no guarantee that it will be valid
> for another conn.
I thought about doing this, but the subsequent para seems to make it clear
enough:
+ <para>
+ If <literal>conn</literal> is NULL, the attributes available for the
+ default SSL library are returned, or an empty list
+ if <application>libpq</application> was compiled without any SSL
+ support. If <literal>conn</literal> is not NULL, the attributes
+ available for the SSL library in use for the connection are returned,
+ or an empty list if the connection is not encrypted.
+ </para>
The actual constraint is "names that can be used on connections using
the same SSL library", which seems too verbose for the introductory
sentence.
> I'd be fine just doing this in HEAD.
Pushed to HEAD only.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, daniel@yesql.se, jchampion@timescale.com, heath.lord@crunchydata.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17625: In PG15 PQsslAttribute returns different values than PG14 when SSL is not in use for the connection
In-Reply-To: <640451.1664548187@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox