From: Tom Lane <tgl@sss.pgh.pa.us>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: hiramit.tm@gmail.com
Cc: kasahara.tatsuhito@gmail.com
Cc: magnus@hagander.net
Cc: andres@anarazel.de
Cc: masao.fujii@oss.nttdata.com
Cc: skoposov@ed.ac.uk
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16722: PG hanging on COPY when table has close to 2^32 toasts in the table.
Date: Sun, 28 Feb 2021 22:00:56 -0500
Message-ID: <666801.1614567656@sss.pgh.pa.us> (raw)
In-Reply-To: <20210301.112452.1902584192027811521.horikyota.ntt@gmail.com>
References: <CAP0=ZVLue4DBqV5cSD63JbXryV7+UKXdukfoLyEOpw+2EHRFCg@mail.gmail.com>
<CAP0=ZVKdHgLGvFJHE_6x2PTrw50_FLqPUSdRNzVTKSb_y8naCQ@mail.gmail.com>
<CAOR2cEb4Suwnk+rvC-Ea1BmOKXTg-nV--N9f+rRo4TEZztN7bg@mail.gmail.com>
<20210301.112452.1902584192027811521.horikyota.ntt@gmail.com>
Kyotaro Horiguchi <horikyota.ntt@gmail.com> writes:
> At Mon, 1 Mar 2021 10:56:50 +0900, tomohiro hiramitsu <hiramit.tm@gmail.com> wrote in
> + ereport(LOG,
> + (errmsg("failed to assign new OID in relation \"%s\" after "UINT64_FORMAT" retries",
> The embedded UINT64_FORMAT makes the message untranslatable on some
> platforms.
Right, we can't put platform-dependent substrings there.
> The format string should
> be handled separately from the message body. You will find an example
> in WalReceiverMain().
Lately we've been using "%llu" or "%lld" for 64-bit values, and explicitly
casting the argument to [unsigned] long long. That seems to work
everywhere now that we always use our own snprintf code, and it's less
notationally painful than other ways.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, horikyota.ntt@gmail.com, hiramit.tm@gmail.com, kasahara.tatsuhito@gmail.com, magnus@hagander.net, andres@anarazel.de, masao.fujii@oss.nttdata.com, skoposov@ed.ac.uk, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16722: PG hanging on COPY when table has close to 2^32 toasts in the table.
In-Reply-To: <666801.1614567656@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox