From: Tom Lane <tgl@sss.pgh.pa.us>
To: Artur Zakirov <zaartur@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: pg_dump crash on identity sequence with not loaded attributes
Date: Tue, 10 Dec 2024 10:29:52 -0500
Message-ID: <66804.1733844592@sss.pgh.pa.us> (raw)
In-Reply-To: <CAKNkYnwTypJPsc258ZwVJ+n_Ti-8VxiQ6Gy4oMPmCA9fKo+KKg@mail.gmail.com>
References: <CAKNkYnwXFBf136=u9UqUxFUVagevLQJ=zGd5BsLhCsatDvQsKQ@mail.gmail.com>
<4137493.1733781111@sss.pgh.pa.us>
<CAKNkYnwTypJPsc258ZwVJ+n_Ti-8VxiQ6Gy4oMPmCA9fKo+KKg@mail.gmail.com>
Artur Zakirov <zaartur@gmail.com> writes:
> On Mon, 9 Dec 2024 at 22:51, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> - if (owning_tab->dobj.dump == DUMP_COMPONENT_NONE &&
>> + if ((owning_tab->dobj.dump & DUMP_COMPONENT_DEFINITION) &&
> I think it is necessary to use negation in this condition.
D'oh, of course. But what's your thoughts on the other points?
Is this what we want to do at all?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, zaartur@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: pg_dump crash on identity sequence with not loaded attributes
In-Reply-To: <66804.1733844592@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox