pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrey Lepikhov <a.lepikhov@postgrespro.ru>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: Negative value of numGroups
Date: Sat, 21 May 2022 13:15:53 -0400
Message-ID: <721706.1653153353@sss.pgh.pa.us> (raw)
In-Reply-To: <26c0c627-65a9-9e38-07f0-56861b75fc68@postgrespro.ru>
References: <ebbc2efb-7ef9-bf2f-1ada-d6ec48f70e58@postgrespro.ru>
	<ed1d1a2d-6061-24e5-e8eb-dbda3ec8f66c@postgrespro.ru>
	<1584431.1652801657@sss.pgh.pa.us>
	<26c0c627-65a9-9e38-07f0-56861b75fc68@postgrespro.ru>

Andrey Lepikhov <a.lepikhov@postgrespro.ru> writes:
> Next version of the patch.
> As I see, now we trying to use Cardinality type instead of double.
> So, I named casting routine as clamp_cardinality_to_long.

Pushed with a bit of rewriting of comments etc.  I left out the
test case too, because (a) for me, it did not reveal any difference
between patched and unpatched code, and (b) even if it had, it was
far too expensive to put into the core regression tests.

			regards, tom lane





view thread (5+ messages)

Message-ID: <721706.1653153353@sss.pgh.pa.us>
Permalink:  ../721706.1653153353@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/721706.1653153353@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, a.lepikhov@postgrespro.ru, pgsql-bugs@lists.postgresql.org
  Subject: Re: Negative value of numGroups
  In-Reply-To: <721706.1653153353@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox