From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Thomas Munro <thomas.munro@enterprisedb.com>
To: Albert Schabhuetl <albert_schabhuetl@yahoo.de>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #15520: PAM authentication + domain socket -> DNS query for symbolic hostname [local]
Date: Mon, 26 Nov 2018 15:02:12 +0100
Message-ID: <72c867be-2e27-fa2c-54e6-7ec26ab5c69b@2ndquadrant.com> (raw)
In-Reply-To: <CAEepm=3N2sA8NKxTTobOLYwZjO=z2n_pQ0P5Fra3Znb5W190cA@mail.gmail.com>
References: <15520-4c266f986998e1c5@postgresql.org>
<CAEepm=016cNC9+Lj_xQOwL+B1XaoofQB8E_qLgPTzea=KfBeWg@mail.gmail.com>
<CAEepm=17Ak+5ZeFjj9OAHj=ZMyeLfYDMYJY-Dt0bqe3ZYioEKw@mail.gmail.com>
<1818527878.10526478.1543176582167@mail.yahoo.com>
<CAEepm=3N2sA8NKxTTobOLYwZjO=z2n_pQ0P5Fra3Znb5W190cA@mail.gmail.com>
On 25/11/2018 23:30, Thomas Munro wrote:
>>> I wonder if anyone out there has come to rely on the value "[local]"
>> I vote for changing it, and documenting it in the release notes.
> Yeah. Here is a draft patch to change that. Test output:
>
> $ psql -h localhost postgres munro
> PAM_USER=munro, PAM_RHOST=localhost
> $ psql postgres munro
> PAM_USER=munro, PAM_RHOST=
I think this is the right thing to do.
About your patch, if we're not going to set PAM_RHOST, then we should
also avoid the call to pg_getnameinfo_all() earlier in CheckPAMAuth().
Look at the original patch linked earlier in the thread; we just need to
put if statements around both of those hunks.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, thomas.munro@enterprisedb.com, albert_schabhuetl@yahoo.de, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15520: PAM authentication + domain socket -> DNS query for symbolic hostname [local]
In-Reply-To: <72c867be-2e27-fa2c-54e6-7ec26ab5c69b@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox