pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Bruno Wolff III <bruno@wolff.to>
Cc: pgsql-bugs@postgresql.org
Subject: Re: Beta 10 parser error for CREATE STATISTICS IF NOT EXISTS
Date: Fri, 23 Jun 2017 09:35:55 +0900
Message-ID: <74102663-d4d0-57ef-ec26-9de49ed40a82@lab.ntt.co.jp> (raw)
In-Reply-To: <20170622172221.qmudrzomu6iolznr@alvherre.pgsql>
References: <20170622172221.qmudrzomu6iolznr@alvherre.pgsql>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-bugs>

On 2017/06/23 2:22, Alvaro Herrera wrote:
> Amit Langote wrote:
>> On 2017/06/21 11:02, Alvaro Herrera wrote:
>>> Bruno Wolff III wrote:
>>>> I'm not seeing an obvious error in my attempt to use CREATE STATISTICS IF
>>>> NOT EXISTS. Given this is new, maybe there is a bug in the parser.
>>>
>>> You're absolutely right, and this is a bug in the parser -- I probably
>>> misplaced the IF NOT EXISTS clause while playing with Tomas' parser
>>> changes.  Here's the fix.  I'm a bit troubled that this change doesn't
>>> seem to affect any tests, so I'll add some before pushing.
>>
>> I posted the same patch but with a test:
>>
>> https://www.postgresql.org/message-id/38b7d52e-387a-0e47-7525-b8b654ca4bfb%40lab.ntt.co.jp
> 
> Pushed.

Thanks, Alvaro.

Regards,
Amit



-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs



view thread (8+ messages)

Message-ID: <74102663-d4d0-57ef-ec26-9de49ed40a82@lab.ntt.co.jp>
Permalink:  ../74102663-d4d0-57ef-ec26-9de49ed40a82@lab.ntt.co.jp/
Also on:    postgresql.org/message-id/74102663-d4d0-57ef-ec26-9de49ed40a82@lab.ntt.co.jp

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: Langote_Amit_f8@lab.ntt.co.jp, alvherre@2ndquadrant.com, bruno@wolff.to
  Subject: Re: Beta 10 parser error for CREATE STATISTICS IF NOT EXISTS
  In-Reply-To: <74102663-d4d0-57ef-ec26-9de49ed40a82@lab.ntt.co.jp>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox