pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: Gustavsson Mikael <mikael.gustavsson@smhi.se>
Cc: pgsql-bugs@lists.postgresql.org, Svensson Peter <peter.svensson@smhi.se>
Cc: Almen Anders <anders.almen@smhi.se>
Subject: Re: SV: Problem with pg_notify / listen
Date: Fri, 27 Nov 2020 23:03:40 -0500
Message-ID: <744927.1606536220@sss.pgh.pa.us> (raw)
In-Reply-To: <20201128035906.GA556656@rfd.leadboat.com>
References: <1b8561412e8a4f038d7a491c8b922788@smhi.se>
	<704331.1606490493@sss.pgh.pa.us>
	<6c10dcdd2eb64bbab4814e4f2abd5ab4@smhi.se>
	<7a0df07fb3f94dfe80839942ab5993c7@smhi.se>
	<716909.1606498665@sss.pgh.pa.us>
	<730247.1606515208@sss.pgh.pa.us>
	<20201128035906.GA556656@rfd.leadboat.com>

Noah Misch <noah@leadboat.com> writes:
> ... agreed.  In general, recycling SLRU space entails three steps that shall
> not overlap:

> 1. Stop reading data in the space, regulated by some "logical tail".
> 2. Unlink files wholly within the bounds of the space.
> 3. Start writing data into the space, regulated by some "physical tail" (most
>    often called a "stop limit").

Check.

> Commit d4031d7 fixed overlap of (2) and (3).  For pg_notify, though, it
> introduced overlap of (1) and (2).  I've now checked the other SLRUs for
> similar problems, but I found nothing urgent:

Good, I was wondering if we had any similar issues elsewhere.

> I think we don't yet have the right name here, seeing QUEUE_TAIL_PAGE !=
> QUEUE_POS_PAGE(QUEUE_TAIL) sounds paradoxical, yet happens regularly.  How
> about naming it QUEUE_STOP_PAGE?

Hmm, it's not very clear what "stop" means here.  What do you think of
QUEUE_OLDEST_PAGE?

			regards, tom lane





view thread (13+ messages)  latest in thread

Message-ID: <744927.1606536220@sss.pgh.pa.us>
Permalink:  ../744927.1606536220@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/744927.1606536220@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, noah@leadboat.com, mikael.gustavsson@smhi.se, peter.svensson@smhi.se, anders.almen@smhi.se
  Subject: Re: SV: Problem with pg_notify / listen
  In-Reply-To: <744927.1606536220@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox