From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: king tomo <t.katsumata1122@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18224: message bug in libpqwalreceiver.c.
Date: Mon, 04 Dec 2023 09:07:29 -0500
Message-ID: <750771.1701698849@sss.pgh.pa.us> (raw)
In-Reply-To: <C35E2C78-AA74-4115-8A25-A3D425349604@yesql.se>
References: <18224-59c34f71e2c6a5ed@postgresql.org>
<CAC55fYeoBvYSyRupWEP+BzGwhdi7R7nvPffM7QhQyqDcpedxig@mail.gmail.com>
<C35E2C78-AA74-4115-8A25-A3D425349604@yesql.se>
Daniel Gustafsson <daniel@yesql.se> writes:
> I've changed
> it to add a comment instead which explains why we check for < 3 and write that
> we expect 4 in the error message. It could be argued that we should say that
> we expect "3 or more" fields but given the age of the change we clearly do
> expect 4 at this point.
I disagree with making this error message lie about what the test was.
Clearly we need to s/3, 1/1, 3/ but I don't think the number should
be different from what we actually allow.
Having said that, maybe there's a case for requiring 4 columns now.
I agree it's pretty unlikely that current releases would see a pre-9.4
server on the other end of the line.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, daniel@yesql.se, t.katsumata1122@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18224: message bug in libpqwalreceiver.c.
In-Reply-To: <750771.1701698849@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox