From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tender Wang <tndrwang@gmail.com>
Cc: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Duncan Sands <duncan.sands@deepbluecap.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: Attribute of type record has wrong type error with MERGE ... WHEN NOT MATCHED BY SOURCE THEN DELETE
Date: Mon, 10 Mar 2025 11:00:46 -0400
Message-ID: <765994.1741618846@sss.pgh.pa.us> (raw)
In-Reply-To: <CAHewXNmuO70GHqZev500b9cGXRbHzU9cDsn2tMWqhv6bXWJ5qQ@mail.gmail.com>
References: <3518c50a-ab18-482f-b916-a37263622501@deepbluecap.com>
<CAHewXNmuO70GHqZev500b9cGXRbHzU9cDsn2tMWqhv6bXWJ5qQ@mail.gmail.com>
Tender Wang <tndrwang@gmail.com> writes:
> When the query has NOT MATCHED BY SOURCE, commit d7d297f84 add "src IS NOT
> NULL" join condition.
> In this case, the src is view(e.g. subquery), so in makeWholeRowVar(), it
> will call below code:
> result = makeVar(varno,
> InvalidAttrNumber,
> RECORDOID,
> -1,
> InvalidOid,
> varlevelsup);
> the vartype is RECORDOID, but te reltype of src is not RECORDOID, so
> $SUBJECT error reports.
Hmm. I tried adjusting the example to make _country_or_region
be a materialized view or plain table instead of a view, and
those cases did not fail. I wonder why the difference...
> I add the below codes to makeWholeRowVar() default branch:
> if (rte->relkind == RELKIND_VIEW)
> toid = get_rel_type_id(rte->relid);
> else
> toid = RECORDOID;
> It can work.
I'm quite uncomfortable with the idea of changing makeWholeRowVar()
itself in this way --- the potential blast radius from that seems
rather large. A localized fix in transform_MERGE_to_join() might
be a wiser answer.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, tndrwang@gmail.com, dean.a.rasheed@gmail.com, duncan.sands@deepbluecap.com, pgsql-bugs@lists.postgresql.org
Subject: Re: Attribute of type record has wrong type error with MERGE ... WHEN NOT MATCHED BY SOURCE THEN DELETE
In-Reply-To: <765994.1741618846@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox