From: Jeff Davis <pgsql@j-davis.com>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Robins Tharakan <tharakan@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@postgresql.org>
Subject: Re: PANIC in heap_delete during ALTER TABLE
Date: Thu, 15 Sep 2022 15:25:30 -0700
Message-ID: <84255ddfad9b98b37fec4d031c4853de344cddea.camel@j-davis.com> (raw)
In-Reply-To: <ccf5707c1d835c0f7ed69b28566e4cc4d7f37189.camel@j-davis.com>
References: <CAEP4nAw9jYQDKd_5Y+-s2E4YiUJq1vqiikFjYGpLShtp-K3gag@mail.gmail.com>
<c0c149af17b358883e95a49984a30360b65f8118.camel@j-davis.com>
<CAH2-Wz=s-ZJJ++wnnKx70iBSCMQ_kiRHD+K3NUX3P3qQcRKAbg@mail.gmail.com>
<ccf5707c1d835c0f7ed69b28566e4cc4d7f37189.camel@j-davis.com>
On Thu, 2022-09-08 at 10:30 -0700, Jeff Davis wrote:
> I wasn't able to repro on 13, but Robins' report indicates that it's
> possible.
I looked again, and I still can't find a way to repro on 13,
specifically the sha1 you mentioned (7cdd0c2d7c).
heap_delete() lets go of its exclusive lock (but not pin) in a couple
places (just like on master). But it looks like all the places that set
PD_ALL_VISIBLE are doing so under a cleanup lock (unlike master), which
means that it can't change for the duration of heap_delete().
I'm hesitant to commit anything here if I can't repro the problem on
13. I must be missing something.
Regards,
Jeff Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: pgsql@j-davis.com, pg@bowt.ie, tharakan@gmail.com
Subject: Re: PANIC in heap_delete during ALTER TABLE
In-Reply-To: <84255ddfad9b98b37fec4d031c4853de344cddea.camel@j-davis.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox