From: Tom Lane <tgl@sss.pgh.pa.us>
To: github@cquest.org
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17163: spgist index scan statistics stays at 0
Date: Fri, 27 Aug 2021 14:33:04 -0400
Message-ID: <862973.1630089184@sss.pgh.pa.us> (raw)
In-Reply-To: <17163-b8c5cc88322a5e92@postgresql.org>
References: <17163-b8c5cc88322a5e92@postgresql.org>
PG Bug reporting form <noreply@postgresql.org> writes:
> The idx_scan in pg_stat_all_indexes stays at 0 for spgist index, while the
> idx_tup_read and idx_tup_fetch and correctly updated.
Hmm, you're right, there's no pgstat_count_index_scan anywhere in
access/spgist/ :-(
The other index AMs do that during the first amgettuple or amgetbitmap
call, but it doesn't look like there is any convenient way to duplicate
that behavior in spgist; none of the code in or below spggettuple or
spggetbitmap is explicitly aware of whether this is the first call.
I'm inclined to propose adding the counter bump in spgrescan. That
isn't *exactly* equivalent semantics, but it would only matter if
someplace called amrescan and then didn't follow through with a scan.
The attached seems to behave as I'd expect.
regards, tom lane
Attachments:
[text/x-diff] count-spgist-indexscans-1.patch (664B, ../862973.1630089184@sss.pgh.pa.us/2-count-spgist-indexscans-1.patch)
download | inline diff:diff --git a/src/backend/access/spgist/spgscan.c b/src/backend/access/spgist/spgscan.cindex e14b9fa573..401a1a8343 100644--- a/src/backend/access/spgist/spgscan.c+++ b/src/backend/access/spgist/spgscan.c@@ -19,6 +19,7 @@
#include "access/relscan.h"
#include "access/spgist_private.h"
#include "miscadmin.h"
+#include "pgstat.h"
#include "storage/bufmgr.h"
#include "utils/datum.h"
#include "utils/float.h"
@@ -419,6 +420,9 @@ spgrescan(IndexScanDesc scan, ScanKey scankey, int nscankeys,
/* set up starting queue entries */
resetSpGistScanOpaque(so);
++ /* count an indexscan for stats */+ pgstat_count_index_scan(scan->indexRelation);
}
void
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, github@cquest.org, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17163: spgist index scan statistics stays at 0
In-Reply-To: <862973.1630089184@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox