pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Euler Taveira <euler@eulerto.com>
Cc: Kong Man <kong_mansatiansin@hotmail.com>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Subject: Re: pg_restore 14 skips ACL COLUMN when --schema is used
Date: Wed, 09 Aug 2023 09:39:20 -0400
Message-ID: <87065.1691588360@sss.pgh.pa.us> (raw)
In-Reply-To: <ece8667d-9824-4740-a150-617c9b3d9284@app.fastmail.com>
References: <DM4PR11MB73976902DBBA10B1D652F9498B06A@DM4PR11MB7397.namprd11.prod.outlook.com>
	<2427882.1690590240@sss.pgh.pa.us>
	<DM4PR11MB7397E0F1BFD8A839199B59838B05A@DM4PR11MB7397.namprd11.prod.outlook.com>
	<DM4PR11MB73970D090F35B7E1C2EEEB108B05A@DM4PR11MB7397.namprd11.prod.outlook.com>
	<90659bbc-e0cb-407d-b42b-5931346735ad@app.fastmail.com>
	<3317367.1691006807@sss.pgh.pa.us>
	<82fd2945-f56f-4e78-b0b5-222848ba8241@app.fastmail.com>
	<ece8667d-9824-4740-a150-617c9b3d9284@app.fastmail.com>

"Euler Taveira" <euler@eulerto.com> writes:
> On Wed, Aug 2, 2023, at 5:53 PM, Euler Taveira wrote:
>> On Wed, Aug 2, 2023, at 5:06 PM, Tom Lane wrote:
>>> Yeah, ignoring dependencies on ACLs in this logic seems like the best
>>> way forward.  Do you want to write a patch?

>> I like your suggestion. Let me give it a try.

Hmm, changing it like that seems likely to have a lot of unexpected
side-effects.  What I had in mind was to change the 

            if (te->nDeps != 1 ||
                TocIDRequired(AH, te->dependencies[0]) == 0)
                return 0;

bit so that it would loop through the TE's dependencies to see
if any one of them is a required non-ACL TE.  We have to relax
the "te->nDeps != 1" restriction, but we still want to check
that there is a parent object that is being restored.

Some work on the associated comment block seems appropriate too.
And maybe add a test case?

			regards, tom lane





view thread (11+ messages)  latest in thread

Message-ID: <87065.1691588360@sss.pgh.pa.us>
Permalink:  ../87065.1691588360@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/87065.1691588360@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, euler@eulerto.com, kong_mansatiansin@hotmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: pg_restore 14 skips ACL COLUMN when --schema is used
  In-Reply-To: <87065.1691588360@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox