From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: Aleksandr Parfenov <a.parfenov@postgrespro.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: PostgreSQL crashes with SIGSEGV
Date: Wed, 28 Mar 2018 13:30:49 -0400
Message-ID: <874.1522258249@sss.pgh.pa.us> (raw)
In-Reply-To: <CAH2-Wzk4MTSPWnCv3ENz9HZrtiJGut8TOtLTaf56AxmJ9VbcEA@mail.gmail.com>
References: <CAH2-Wz=zaO+Suf7my-hyLWPbRB+Mx9CrPgbgBnGwXduoLaiRfQ@mail.gmail.com>
<CAH2-Wzm0CR+4yQ1k9miXmv0Lk0Nse3WVB1RBj1ipm0hAcP3ugA@mail.gmail.com>
<CAH2-Wz=QW6FNpLEfQpFKmKiu_WkfxCpmPDmp6ZUf=7SrARsNpQ@mail.gmail.com>
<20180326.211438.61614860.horiguchi.kyotaro@lab.ntt.co.jp>
<CAH2-Wzk4MTSPWnCv3ENz9HZrtiJGut8TOtLTaf56AxmJ9VbcEA@mail.gmail.com>
Peter Geoghegan <pg@bowt.ie> writes:
> On Mon, Mar 26, 2018 at 5:14 AM, Kyotaro HORIGUCHI
> <horiguchi.kyotaro@lab.ntt.co.jp> wrote:
>> If no one objects, I'll mark this as Ready for Commit in a couple
>> of days.
> Thank you for the review, Horiguchi-san. It's hard to decide how
> important each goal is when coming up with a back-patchable fix like
> this. When the goals are somewhat in competition with each other, a
> second or a third opinion is particularly appreciated.
It looks good to me. The only real objection would be if someone came
up with a test case proving that there's a significant performance
degradation from the extra copies. But given that these are back
branches, it would take a pretty steep penalty for me to want to take
the risk of refactoring to avoid that.
I've pushed it with some cosmetic adjustments.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, pg@bowt.ie, horiguchi.kyotaro@lab.ntt.co.jp, a.parfenov@postgrespro.ru, pgsql-hackers@lists.postgresql.org
Subject: Re: PostgreSQL crashes with SIGSEGV
In-Reply-To: <874.1522258249@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox