pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: n.lutic@loxodata.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17486: [pg_restore] Restoring a view fails if this view contains an attribute without alias name.
Date: Sat, 21 May 2022 14:47:02 -0400
Message-ID: <880598.1653158822@sss.pgh.pa.us> (raw)
In-Reply-To: <EC735F33-1AA3-4FA9-8054-0C949B70AB15@yesql.se>
References: <17486-1ad6fd786728b8af@postgresql.org>
	<792E8C73-EBE0-41FC-A83F-2F7A7AF4ABBB@yesql.se>
	<334334.1653057260@sss.pgh.pa.us>
	<310D60C6-5CF0-41C8-A814-3A3DE7ACF551@yesql.se>
	<347193.1653059973@sss.pgh.pa.us>
	<428377.1653066358@sss.pgh.pa.us>
	<EC735F33-1AA3-4FA9-8054-0C949B70AB15@yesql.se>

Daniel Gustafsson <daniel@yesql.se> writes:
> On 20 May 2022, at 19:05, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I thought of a compromise position that's not hard to implement:
>> change the behavior only if the SELECT output column name is *possibly*
>> visible elsewhere, which it is not in (for example) an EXISTS subquery.

> Nice one!  I think that's even better than the previous version actually.
> Skimming the patch it seems like a reasonable approach.

Pushed, thanks for looking.

			regards, tom lane





view thread (8+ messages)

Message-ID: <880598.1653158822@sss.pgh.pa.us>
Permalink:  ../880598.1653158822@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/880598.1653158822@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, daniel@yesql.se, n.lutic@loxodata.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #17486: [pg_restore] Restoring a view fails if this view contains an attribute without alias name.
  In-Reply-To: <880598.1653158822@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox