From: Tom Lane <tgl@sss.pgh.pa.us>
To: d.kovalenko@postgrespro.ru
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18981: Fault tolerance and improvement for xmltotext_with_options (xml.c)
Date: Tue, 08 Jul 2025 12:51:56 -0400
Message-ID: <882827.1751993516@sss.pgh.pa.us> (raw)
In-Reply-To: <18981-9bc3c80f107ae925@postgresql.org>
References: <18981-9bc3c80f107ae925@postgresql.org>
PG Bug reporting form <noreply@postgresql.org> writes:
> Please look at this code:
> https://github.com/postgres/postgres/blob/a27893df45ec5d8c657899202e9cf0b9a816fe2f/src/backend/utils...
> xmlerrcxt = pg_xml_init(PG_XML_STRICTNESS_ALL);
> pg_xml_init uses palloc and may "raise an exception".
Yup, we should cover that case.
> Also
> Within PG_CATCH 'doc' is not NULL.
Agreed. Pushed your fix with small editorialization.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, d.kovalenko@postgrespro.ru, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18981: Fault tolerance and improvement for xmltotext_with_options (xml.c)
In-Reply-To: <882827.1751993516@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox