From: Wood, Dan <hexpert@amazon.com>
To: Peter Geoghegan <pg@bowt.ie>
Cc: pgsql-bugs@postgresql.org <pgsql-bugs@postgresql.org>
Subject: Re: Old row version in hot chain become visible after a freeze
Date: Thu, 31 Aug 2017 23:20:04 +0000
Message-ID: <897E6768-98C1-43C5-B743-DF060A7C2D0E@amazon.com> (raw)
In-Reply-To: <CAH2-Wz=cHGRPoXkYgi+rxg1TEMqf79DiiN7qq_yoHAL8mAfR0w@mail.gmail.com>
References: <E5711E62-8FDF-4DCA-A888-C200BF6B5742@amazon.com>
<CAH2-Wz=cHGRPoXkYgi+rxg1TEMqf79DiiN7qq_yoHAL8mAfR0w@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-bugs>
I was aware of the other one and, in fact, reverted the change just to make sure it wasn’t Involved. A strange coincidence indeed.
On 8/31/17, 3:57 PM, "Peter Geoghegan" <pg@bowt.ie> wrote:
Hi Dan,
Nice to hear from you.
On Thu, Aug 31, 2017 at 3:36 PM, Wood, Dan <hexpert@amazon.com> wrote:
> Because tupgone is false we freeze instead of deleting. Freezing a DEAD
> tuple makes it visible. Here is a comment in heap_prepare_freeze_tuple()
>
>
>
> * It is assumed that the caller has checked the tuple with
>
> * HeapTupleSatisfiesVacuum() and determined that it is not HEAPTUPLE_DEAD
Funny that there'd be another bug associated with
heap_prepare_freeze_tuple() so soon after the last one was discovered.
Are you aware of the other one [1]?
BTW, I just posted a patch to enhance amcheck, to allow it to verify
that an index has all the entries that it ought to [2]. Perhaps you'd
find it useful for this kind of thing. I welcome your feedback on
that.
[1] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=31b8db8e6c1fa4436116f4be5ca789f3a...
[2] https://commitfest.postgresql.org/14/1263/
--
Peter Geoghegan
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: hexpert@amazon.com, pg@bowt.ie
Subject: Re: Old row version in hot chain become visible after a freeze
In-Reply-To: <897E6768-98C1-43C5-B743-DF060A7C2D0E@amazon.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox