From: Jonathan S. Katz <jkatz@postgresql.org>
To: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David Rowley <dgrowleyml@gmail.com>
Cc: exclusion@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18240: Undefined behaviour in cash_mul_flt8() and friends
Date: Fri, 12 Jan 2024 11:19:08 -0500
Message-ID: <9115f2e8-8dde-4545-868c-9becb2260aef@postgresql.org> (raw)
In-Reply-To: <ZZ9AdxEEwHD8CWJ5@paquier.xyz>
References: <ZXgh74Ykj3iWvXKr@paquier.xyz>
<CAApHDvrBLa=gQ0tCg8727RaZXWDg1sDvFJ2+-DVy5SC=NSSKkg@mail.gmail.com>
<2433182.1702391878@sss.pgh.pa.us>
<ZX1rmhppwgaczYQ7@paquier.xyz>
<3453263.1702739958@sss.pgh.pa.us>
<ecdf4a19-e97d-42c8-be45-fb5a46166160@postgresql.org>
<1673413.1703442075@sss.pgh.pa.us>
<ZYjSZZu1UGUlXWXa@paquier.xyz>
<ZYlSJREbhM_qNZIT@paquier.xyz>
<1851211.1703519939@sss.pgh.pa.us>
<ZZ9AdxEEwHD8CWJ5@paquier.xyz>
On 1/10/24 8:12 PM, Michael Paquier wrote:
> While looking at the whole picture, an issue with the direct removal
> of money is how we should handle btree_gin and btree_gist which have
> operators based on money. We try to keep things compatible at
> run-time, but could this be worth a hard break in these modules,
> dropping the older sql scripts used in the modules if we don't have
> access to money anymore at runtime? These are not popular modules..
> Any thoughts about that?
Both modules are pretty popular. Personally, I used it in scheduling
apps that involved range types + exclusion constraints. The data I've
seen suggests btree_gist / btree_gin are widely deployed.
That said, I don't know how much of these modules are used with the
money type specifically. My guess is that it's more common to combine it
with something like an {int,bool}/range type than a money type.
It sounds like we'd have to tread a bit lightly because of this, even if
money is not frequently (or at all) used with btree_gist/gin?
Jonathan
Attachments:
OpenPGP_signature.asc (application/pgp-signature, 839B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: jkatz@postgresql.org, michael@paquier.xyz, tgl@sss.pgh.pa.us, dgrowleyml@gmail.com, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18240: Undefined behaviour in cash_mul_flt8() and friends
In-Reply-To: <9115f2e8-8dde-4545-868c-9becb2260aef@postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox