From: Tom Lane <tgl@sss.pgh.pa.us>
To: Stephen Frost <sfrost@snowman.net>
Cc: Wolfgang Walther <walther@technowledgy.de>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: User with BYPASSRLS privilege can't change password
Date: Tue, 03 Nov 2020 13:17:23 -0500
Message-ID: <958390.1604427443@sss.pgh.pa.us> (raw)
In-Reply-To: <20201103180641.GX16415@tamriel.snowman.net>
References: <a5548a9f-89ee-3167-129d-162b5985fcf8@technowledgy.de>
<923005.1604420579@sss.pgh.pa.us>
<956994.1604425451@sss.pgh.pa.us>
<20201103180641.GX16415@tamriel.snowman.net>
Stephen Frost <sfrost@snowman.net> writes:
>> @@ -739,7 +741,6 @@ AlterRole(AlterRoleStmt *stmt)
>> createrole < 0 &&
>> createdb < 0 &&
>> canlogin < 0 &&
>> - isreplication < 0 &&
>> !dconnlimit &&
>> !rolemembers &&
>> !validUntil &&
> This seems like an independent change..? Not saying it's wrong though.
That test is redundant, since we wouldn't be in this path at all if
isreplication >= 0. You could alternatively argue that this should
redundantly test all three of issuper, isreplication, and bypassrls;
but testing just one of them is confusing and hence bug-prone.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, sfrost@snowman.net, walther@technowledgy.de, pgsql-bugs@lists.postgresql.org
Subject: Re: User with BYPASSRLS privilege can't change password
In-Reply-To: <958390.1604427443@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox