pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: David Rowley <dgrowleyml@gmail.com>
Cc: gparc@free.fr, pgsql-bugs <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #18295: In PostgreSQL a unique index on targeted columns is sufficient to support a foreign key
Date: Mon, 29 Jan 2024 09:59:05 +0100
Message-ID: <971235d021e8b501e8a5d1bb4b07309767800d96.camel@cybertec.at> (raw)
In-Reply-To: <CAApHDvqyt4mwCJv8X8oPOc9oqKKCsFD3p8V5D83afuP60Fv_bg@mail.gmail.com>
References: <18295-0ed0fac5c9f7b17b@postgresql.org>
	<1142099713.208806083.1706091077854.JavaMail.zimbra@free.fr>
	<51c67d44ee2c5c888d9842110a27b9f9c329cb5e.camel@cybertec.at>
	<1963986314.213748462.1706112064903.JavaMail.zimbra@free.fr>
	<1197950598.222716079.1706196971222.JavaMail.zimbra@free.fr>
	<87bde9f9c7fe5467617c303e63a380a17f0b2600.camel@cybertec.at>
	<CAApHDvoaMq1oGxJbfVK4Miwp=0DbhuTJhkUuYOw-Q=WkOmH-qQ@mail.gmail.com>
	<763b0bc3828415afa5f815753100722611faa1e9.camel@cybertec.at>
	<CAApHDvpMps521Pih_ccrffzyv0SFtC0TuB6vULqhrrxzfW+o3w@mail.gmail.com>
	<578afb7d3a88969b4d77f49280cd30247ee4b687.camel@cybertec.at>
	<CAApHDvqyt4mwCJv8X8oPOc9oqKKCsFD3p8V5D83afuP60Fv_bg@mail.gmail.com>

Thanks for your updated patch!

On Mon, 2024-01-29 at 21:42 +1300, David Rowley wrote:

> I also ended up fiddling with the "foreign-key" vs "foreign key"
> thing. I didn't expect you to change the existing ones and on changing
> the new one to "foreign-key", I thought it looked weird.  Maybe we
> need a master-only patch to make these consistent...

Hm.  With your changes, the title reads "Foreign-Key Constraints", but
the body uses "foreign key constraint".  I think they should be consistent.

I'd be happy with either variant, but since the hyphenated version
isn't used anywhere else on the page, my opinion is that we should do
away with it.

Other than that, your patch looks good to me.

Yours,
Laurenz Albe





view thread (15+ messages)  latest in thread

Message-ID: <971235d021e8b501e8a5d1bb4b07309767800d96.camel@cybertec.at>
Permalink:  ../971235d021e8b501e8a5d1bb4b07309767800d96.camel@cybertec.at/
Also on:    postgresql.org/message-id/971235d021e8b501e8a5d1bb4b07309767800d96.camel@cybertec.at

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: laurenz.albe@cybertec.at, dgrowleyml@gmail.com
  Subject: Re: BUG #18295: In PostgreSQL a unique index on targeted columns is sufficient to support a foreign key
  In-Reply-To: <971235d021e8b501e8a5d1bb4b07309767800d96.camel@cybertec.at>
  References: <18295-0ed0fac5c9f7b17b@postgresql.org> <1142099713.208806083.1706091077854.JavaMail.zimbra@free.fr> <51c67d44ee2c5c888d9842110a27b9f9c329cb5e.camel@cybertec.at> <1963986314.213748462.1706112064903.JavaMail.zimbra@free.fr> <1197950598.222716079.1706196971222.JavaMail.zimbra@free.fr> <87bde9f9c7fe5467617c303e63a380a17f0b2600.camel@cybertec.at> <CAApHDvoaMq1oGxJbfVK4Miwp=0DbhuTJhkUuYOw-Q=WkOmH-qQ@mail.gmail.com> <763b0bc3828415afa5f815753100722611faa1e9.camel@cybertec.at> <CAApHDvpMps521Pih_ccrffzyv0SFtC0TuB6vULqhrrxzfW+o3w@mail.gmail.com> <578afb7d3a88969b4d77f49280cd30247ee4b687.camel@cybertec.at> <CAApHDvqyt4mwCJv8X8oPOc9oqKKCsFD3p8V5D83afuP60Fv_bg@mail.gmail.com> <971235d021e8b501e8a5d1bb4b07309767800d96.camel@cybertec.at>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox