pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Ranier Vilela <ranier_gyn@hotmail.com>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Subject: Re: [BUG] Uninitializaed configOut.leafType used.
Date: Wed, 13 Nov 2019 14:13:51 -0500
Message-ID: <9796.1573672431@sss.pgh.pa.us> (raw)
In-Reply-To: <20191113182013.3rpzaozpqisnzzps@alap3.anarazel.de>
References: <MN2PR18MB29278AACBEABDEDA2951A32EE3760@MN2PR18MB2927.namprd18.prod.outlook.com>
	<32631.1573665493@sss.pgh.pa.us>
	<MN2PR18MB29278ED3DCF436F92D144451E3760@MN2PR18MB2927.namprd18.prod.outlook.com>
	<20191113180320.gl27ldjjgex2x6ad@alap3.anarazel.de>
	<MN2PR18MB29278BBF41FBAD99627BA1C6E3760@MN2PR18MB2927.namprd18.prod.outlook.com>
	<20191113182013.3rpzaozpqisnzzps@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> It certainly could be more obvious. I'm not a fan of the spgist code :(.

Yeah.  The claimed problem is unreachable, because the only way to get
there is for configOutLefttype/configOutRighttype to have been set to
something valid by a previous execution of the SPGIST_CONFIG_PROC case.
However, if the proclist members don't appear in numerical sequence,
we'd get a bogus failure because the "ok = false" path would be taken.
That "if" is true normally because of the way the catcache works, but
I think it's possible to make it fail if you disable system index usage.
Not a realistic scenario in practice, but less robust than I'd like.
Can't get terribly excited about fixing it though.

			regards, tom lane





view thread (8+ messages)

Message-ID: <9796.1573672431@sss.pgh.pa.us>
Permalink:  ../9796.1573672431@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/9796.1573672431@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, ranier_gyn@hotmail.com
  Subject: Re: [BUG] Uninitializaed configOut.leafType used.
  In-Reply-To: <9796.1573672431@sss.pgh.pa.us>
  References: <MN2PR18MB29278AACBEABDEDA2951A32EE3760@MN2PR18MB2927.namprd18.prod.outlook.com> <32631.1573665493@sss.pgh.pa.us> <MN2PR18MB29278ED3DCF436F92D144451E3760@MN2PR18MB2927.namprd18.prod.outlook.com> <20191113180320.gl27ldjjgex2x6ad@alap3.anarazel.de> <MN2PR18MB29278BBF41FBAD99627BA1C6E3760@MN2PR18MB2927.namprd18.prod.outlook.com> <20191113182013.3rpzaozpqisnzzps@alap3.anarazel.de> <9796.1573672431@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox