From: Tom Lane <tgl@sss.pgh.pa.us>
To: Imran Zaheer <imran.zhir@gmail.com>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: masano@sraoss.co.jp
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18336: Inconsistency in PostgreSQL 16 Documentation for SHOW Command
Date: Sat, 17 Aug 2024 14:12:40 -0400
Message-ID: <980689.1723918360@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+UBfakwizA81tWW_ZfPC5bF7T_anptC+uo_x=uWep4gJPWJhg@mail.gmail.com>
References: <18336-d3652b898b550423@postgresql.org>
<94d001ada27f1b39f00370a784395667aa6d44aa.camel@cybertec.at>
<f1fcbfd3-c12c-4aad-9f8e-fbaee3ef5658@eisentraut.org>
<d37f392a885435b8dc9e77d98c7191051d83da5c.camel@cybertec.at>
<CA+UBfakwizA81tWW_ZfPC5bF7T_anptC+uo_x=uWep4gJPWJhg@mail.gmail.com>
Imran Zaheer <imran.zhir@gmail.com> writes:
> The website[1] still shows the redundant LC_COLLATE & LC_CTYPE params.
> Are we planning to update them?
This patch seems to have fallen through the cracks. I thought
I'd go apply it, but on closer inspection the cross-reference
to SET seems to indicate we have some more work to do.
That's because set.sgml has its own list of "special" names.
It'd be fine if SHOW recognized exactly the same list of special
names, but it seems to recognize only some of them:
regression=# set time zone 'America/New_York';
SET
regression=# show time zone;
TimeZone
------------------
America/New_York
(1 row)
regression=# set names 'LATIN1';
SET
regression=# show names;
ERROR: unrecognized configuration parameter "names"
Digging in gram.y, I see that VariableShowStmt actually has these options:
SHOW var_name
| SHOW TIME ZONE
| SHOW TRANSACTION ISOLATION LEVEL
| SHOW SESSION AUTHORIZATION
| SHOW ALL
which is a subset of the special cases in VariableSetStmt (many
of which don't seem to be documented anywhere, although I suppose
most or all are derived from the SQL spec). I wonder if we ought
to try to make that more systematic. I don't see a really good
reason why SHOW shouldn't have exactly the same list of special
target-name syntaxes as SET.
In short: we might end up applying exactly this patch to show.sgml,
but we'd have to do some work elsewhere to make the cross-ref to
set.sgml not still be a lie. Maybe we should go ahead and commit
it as-is anyway, since it's better than what we have.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, imran.zhir@gmail.com, laurenz.albe@cybertec.at, peter@eisentraut.org, masano@sraoss.co.jp, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18336: Inconsistency in PostgreSQL 16 Documentation for SHOW Command
In-Reply-To: <980689.1723918360@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox