pg.ddx.io pgsql-bugs@postgresql.org mailing list archive
help / color / mirror / Atom feedFrom: Jonathan S. Katz <jkatz@postgresql.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-bugs@lists.postgresql.org
Cc: heath.lord@crunchydata.com
Subject: Re: BUG #16259: Cannot Use "pg_ctl start -l logfile" on Clean Install on Windows Server 2012/2016
Date: Fri, 14 Feb 2020 13:04:06 -0500
Message-ID: <98b2f7d0-9010-358a-36c9-a5b09020dd08@postgresql.org> (raw)
In-Reply-To: <22619.1581702327@sss.pgh.pa.us>
References: <16259-c5ebed32a262a8b1@postgresql.org>
<22619.1581702327@sss.pgh.pa.us>
+Heath
On 2/14/20 12:45 PM, Tom Lane wrote:
> PG Bug reporting form <noreply@postgresql.org> writes:
>> When testing PostgreSQL 12.2 on Windows built using MSVC (this potentially
>> affects mingw too, though untested) on both Windows Server 2012 & 2016, we
>> are having issues with a newly generated log file on a fresh PostgreSQL
>> cluster when PostgreSQL is started with pg_ctl. If the log file was created
>> with a prior version of PostgreSQL, or if you manually create the log file
>> and grant the executing user the appropriate file access permissions,
>> everything works fine.
>> In other words, the issue occurs when passing a file name to the `-l` flag
>> where the log file does not already exist.
>
> So ... why aren't we seeing that in the buildfarm? The TAP tests
> certainly do that, and I think the core regression tests do too.
Heath can speak to this one. He's currently looking at Dory to see why
that is.
Per my quick look, there's only one animal that has Windows Server 2016
(Dory) and none with 2012.
>> We think this was introduced in 0da33c76. One approach for a fix would be to
>> add a condition so the added code only executes if the file already exists,
>> and if the file does not exist it executes the "snprintf" command like
>> before.
>
> Without an explanation for why it's not failing everywhere, I don't
> have a lot of faith in that being an improvement.
Sure, mostly was to find a starting point.
Jonathan
Attachments:
[application/pgp-signature] signature.asc (832B, ../98b2f7d0-9010-358a-36c9-a5b09020dd08@postgresql.org/2-signature.asc)
download
view thread (11+ messages) latest in thread
Message-ID: <98b2f7d0-9010-358a-36c9-a5b09020dd08@postgresql.org>
Permalink: ../98b2f7d0-9010-358a-36c9-a5b09020dd08@postgresql.org/
Also on: postgresql.org/message-id/98b2f7d0-9010-358a-36c9-a5b09020dd08@postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: jkatz@postgresql.org, tgl@sss.pgh.pa.us, pgsql-bugs@lists.postgresql.org, heath.lord@crunchydata.com
Subject: Re: BUG #16259: Cannot Use "pg_ctl start -l logfile" on Clean Install on Windows Server 2012/2016
In-Reply-To: <98b2f7d0-9010-358a-36c9-a5b09020dd08@postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox