From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Amit Langote <amitlangote09@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: jianingy.yang@gmail.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: BUG #15672: PostgreSQL 11.1/11.2 crashed after dropping a partition table
Date: Fri, 26 Apr 2019 14:57:49 -0400
Message-ID: <9943.1556305069@sss.pgh.pa.us> (raw)
In-Reply-To: <20190426153921.GA22956@alvherre.pgsql>
References: <20190426153921.GA22956@alvherre.pgsql>
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Um, this one doesn't apply because of yesterday's 87259588d0ab.
Before we spend too much time on minutiae, we should ask ourselves whether
this patch is even going in the right direction. I'm not sure.
One point is that if we simply adopt the old index as-is, we won't see
any updates in its metadata. An example is that if we have an index
on a varchar(10) column, and we alter the column to varchar(12),
the current behavior is to generate a new index that agrees with that:
regression=# create table pp(f1 varchar(10) unique);
CREATE TABLE
regression=# \d pp_f1_key
Index "public.pp_f1_key"
Column | Type | Key? | Definition
--------+-----------------------+------+------------
f1 | character varying(10) | yes | f1
unique, btree, for table "public.pp"
regression=# alter table pp alter column f1 type varchar(12);
ALTER TABLE
regression=# \d pp_f1_key
Index "public.pp_f1_key"
Column | Type | Key? | Definition
--------+-----------------------+------+------------
f1 | character varying(12) | yes | f1
unique, btree, for table "public.pp"
With this patch, I believe, the index column will still claim to be
varchar(10). Is that OK? It might not actually break anything
right now, but at the very least it's likely to be confusing.
Also, it'd essentially render the declared types/typmods of index
columns untrustworthy, which seems like something that would come
back to bite us.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, Langote_Amit_f8@lab.ntt.co.jp, amitlangote09@gmail.com, michael@paquier.xyz, pgsql-bugs@lists.postgresql.org, pgsql-hackers@postgresql.org
Subject: Re: BUG #15672: PostgreSQL 11.1/11.2 crashed after dropping a partition table
In-Reply-To: <9943.1556305069@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox