pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
To: Michael Paquier <michael@paquier.xyz>
Cc: Luis Carril <luis.carril@swarm64.com>
Cc: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Cc: PG Bug reporting form <noreply@postgresql.org>
Cc: Michael Paquier <michael.paquier@gmail.com>
Subject: Re: BUG #15552: Unexpected error in COPY to a foreign table in a transaction
Date: Wed, 19 Dec 2018 13:01:01 +0900
Message-ID: <9c0508a1-da8e-b122-a3c7-61b2cbe4e10c@lab.ntt.co.jp> (raw)
In-Reply-To: <20181219035157.GB6577@paquier.xyz>
References: <15552-c64aa14c5c22f63c@postgresql.org>
	<8e82d10d-cc16-eed4-7634-3654f59d8053@lab.ntt.co.jp>
	<LEJPR01MB00109D0BECB8A961074A7CAFE7BC0@LEJPR01MB0010.DEUPRD01.PROD.OUTLOOK.DE>
	<30718b48-8020-329a-c6f0-74e1222e5283@lab.ntt.co.jp>
	<5C18ECBB.2000507@lab.ntt.co.jp>
	<LEJPR01MB001074FD67CB65B539122E4DE7BD0@LEJPR01MB0010.DEUPRD01.PROD.OUTLOOK.DE>
	<3539e73a-313a-5406-27c7-850affb47921@lab.ntt.co.jp>
	<20181219023814.GA6577@paquier.xyz>
	<6daa6d4a-d4a9-bd2c-0b84-c4e31d2b9844@lab.ntt.co.jp>
	<20181219035157.GB6577@paquier.xyz>

On 2018/12/19 12:51, Michael Paquier wrote:
> On Wed, Dec 19, 2018 at 11:52:09AM +0900, Amit Langote wrote:
>> Hmm, note that we don't pass CopyState->freeze option to the FDW drivers
>> today, though we may in the future when we add an *actual* COPY interface
>> to FDWs.  Wouldn't it be a good idea to prevent specifying the FREEZE
>> option for foreign tables as COPY targets until then?  Of course, that's
>> something for -hackers to consider.
> 
> No idea if that will happen.

It may happen sooner that you may think. :)

Currently, COPY into foreign tables uses APIs used by INSERT, so one row
at a time interface.  It'd certainly be better to allow FDWs to be able to
do bulk transfer.  I think Fujita-san has said he wants to work on that:

https://www.postgresql.org/message-id/5AB4F190.1000804%40lab.ntt.co.jp

> One argument for doing nothing yet is that
> this command does not fail now so changing it may cause compatibility
> problems.

Just FYI, COPYing into foreign tables is only supported as of PG 11.

Thanks,
Amit






view thread (37+ messages)  latest in thread

Message-ID: <9c0508a1-da8e-b122-a3c7-61b2cbe4e10c@lab.ntt.co.jp>
Permalink:  ../9c0508a1-da8e-b122-a3c7-61b2cbe4e10c@lab.ntt.co.jp/
Also on:    postgresql.org/message-id/9c0508a1-da8e-b122-a3c7-61b2cbe4e10c@lab.ntt.co.jp

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: Langote_Amit_f8@lab.ntt.co.jp, michael@paquier.xyz, luis.carril@swarm64.com, fujita.etsuro@lab.ntt.co.jp, pgsql-bugs@lists.postgresql.org, noreply@postgresql.org, michael.paquier@gmail.com
  Subject: Re: BUG #15552: Unexpected error in COPY to a foreign table in a transaction
  In-Reply-To: <9c0508a1-da8e-b122-a3c7-61b2cbe4e10c@lab.ntt.co.jp>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox