pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Bossart, Nathan <bossartn@amazon.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Neil Chen <carpenter.nail.cz@gmail.com>
Cc: Boris P. Korzun <drtr0jan@yandex.ru>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Subject: Re: Inconsistent behavior of pg_dump/pg_restore on DEFAULT PRIVILEGES
Date: Mon, 18 Oct 2021 23:46:56 +0000
Message-ID: <AB89F451-ED7F-4FA6-ADF8-F8132220D6A2@amazon.com> (raw)
In-Reply-To: <CAD21AoDRg1E7AEM_5ifyjFbQ71J303OHA-R1HjzqC0FT306dKQ@mail.gmail.com>
References: <CAA3qoJnr2+1dVJObNtfec=qW4Z0nz=A9+r5bZKoTSy5RDjskMw@mail.gmail.com>
	<8261632200581@mail.yandex.ru>
	<CAA3qoJ=f6jZAkkfwH+rtH_8C9z-nfcgNFYZnGYxVdBjz7Vkhig@mail.gmail.com>
	<CAD21AoBrCbjiJt3OCDQCLrM6OQOxjV9cAyM6bn4=SjHq0konBQ@mail.gmail.com>
	<CAD21AoC+m46JEsFE2d6JQuPuNN5ODj1vpZ3z2HtPdn+HFDJfdg@mail.gmail.com>
	<721942.1634180151@sss.pgh.pa.us>
	<CAD21AoAUCNCo77LJLAFGEkhtgruMpzPD153SC7dY7TyahvM_Fg@mail.gmail.com>
	<YWfh9O/36r+GlgNB@paquier.xyz>
	<CAD21AoDRg1E7AEM_5ifyjFbQ71J303OHA-R1HjzqC0FT306dKQ@mail.gmail.com>

On 10/14/21, 5:06 PM, "Masahiko Sawada" <sawada.mshk@gmail.com> wrote:
> The current pg_dump produced a REVOKE ALL ON TABLES FROM
> regress_dump_test_role but it seems unnecessary. The patch removes it
> so looks good to me too.

+1

If we are going to proceed with the patch in this thread, I think we
should also mention in the comment that we are depending on
acldefault() being STRICT.  This patch is quite a bit smaller than
what I had proposed, but AFAICT it produces the same result.

Nathan



view thread (26+ messages)  latest in thread

Message-ID: <AB89F451-ED7F-4FA6-ADF8-F8132220D6A2@amazon.com>
Permalink:  ../AB89F451-ED7F-4FA6-ADF8-F8132220D6A2@amazon.com/
Also on:    postgresql.org/message-id/AB89F451-ED7F-4FA6-ADF8-F8132220D6A2@amazon.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: bossartn@amazon.com, sawada.mshk@gmail.com, michael@paquier.xyz, tgl@sss.pgh.pa.us, carpenter.nail.cz@gmail.com, drtr0jan@yandex.ru, pgsql-bugs@lists.postgresql.org
  Subject: Re: Inconsistent behavior of pg_dump/pg_restore on DEFAULT PRIVILEGES
  In-Reply-To: <AB89F451-ED7F-4FA6-ADF8-F8132220D6A2@amazon.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox