From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Kieran McCusker <kieran.mccusker@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: plpython does not honour max-rows
Date: Tue, 2 May 2023 22:50:17 +0200
Message-ID: <B5ECE886-8D9F-49D5-AC55-A3CC5353FBAC@yesql.se> (raw)
In-Reply-To: <2830145.1683059955@sss.pgh.pa.us>
References: <CAGgUQ6H6qYScctOhktQ9HLFDDoafBKHyUgJbZ6q_dOApnzNTXg@mail.gmail.com>
<711512C7-2BC2-4901-A368-6A5A23023F72@yesql.se>
<CAGgUQ6GBpw-vkzxuuTk3au8Hq+YezG5sv3yR=YjE3CbOqp-a3Q@mail.gmail.com>
<D2132F23-B3AF-4D98-9859-BC2B64A599EC@yesql.se>
<CAGgUQ6FMfBrCTeu7DLUmmsSVn0zu02mx7xZ39etb26pAqTrM+w@mail.gmail.com>
<2678018.1683036150@sss.pgh.pa.us>
<F0A43D83-EA33-4909-A002-1C401ACE1049@yesql.se>
<2830145.1683059955@sss.pgh.pa.us>
> On 2 May 2023, at 22:39, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Daniel Gustafsson <daniel@yesql.se> writes:
>>> On 2 May 2023, at 16:02, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> I wonder whether the similar plperl and pltcl wrappers are also
>>> documentation-shy here.
>
>> It seems like they are all a bit thin on explaining this. The attached diff
>> copies the wording (which unsurprisingly is pretty good IMO) into the
>> plperl/python/tcl documentation.
>
> Ah, seems like we set to work on this at the same time :-(
Pretty impressive timing across timezones =)
> I thought that s/max-rows/limit/ would be a good idea,
I was actually thinking about that but backed off to not confuse things with
LIMIT.
> mainly because
> plperl's spi_exec_prepared uses that name as a caller-exposed hash key.
But I didn't realize that, and in light of that I agree that limit is better.
> I'm not especially concerned about the wording otherwise.
Neither am I, both are fine I think.
--
Daniel Gustafsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-bugs@postgresql.org
Cc: daniel@yesql.se, tgl@sss.pgh.pa.us, kieran.mccusker@gmail.com
Subject: Re: plpython does not honour max-rows
In-Reply-To: <B5ECE886-8D9F-49D5-AC55-A3CC5353FBAC@yesql.se>
References: <CAGgUQ6H6qYScctOhktQ9HLFDDoafBKHyUgJbZ6q_dOApnzNTXg@mail.gmail.com> <711512C7-2BC2-4901-A368-6A5A23023F72@yesql.se> <CAGgUQ6GBpw-vkzxuuTk3au8Hq+YezG5sv3yR=YjE3CbOqp-a3Q@mail.gmail.com> <D2132F23-B3AF-4D98-9859-BC2B64A599EC@yesql.se> <CAGgUQ6FMfBrCTeu7DLUmmsSVn0zu02mx7xZ39etb26pAqTrM+w@mail.gmail.com> <2678018.1683036150@sss.pgh.pa.us> <F0A43D83-EA33-4909-A002-1C401ACE1049@yesql.se> <2830145.1683059955@sss.pgh.pa.us> <B5ECE886-8D9F-49D5-AC55-A3CC5353FBAC@yesql.se>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox