public inbox for [email protected]  

help / color / mirror / Atom feed
From: Ayush Tiwari <[email protected]>
To: Fujii Masao <[email protected]>
Cc: Калинин Никита <[email protected]>
Cc: PostgreSQL mailing lists <[email protected]>
Subject: Re: BUG #19508: pg_buffercache_pages() crashes the backend with an incompatible caller-supplied record definition
Date: Fri, 5 Jun 2026 14:17:58 +0530
Message-ID: <CAJTYsWWqUf2bEAwGfaJvLmokRXBn4yGKVD=jmysnQV9dmv1fwA@mail.gmail.com> (raw)
In-Reply-To: <CAHGQGwHnVc97gVZU22zwRQjbhAWQy0Jgm0yrAErgxROSbuAsXg@mail.gmail.com>
References: <[email protected]>
	<CAHGQGwGaC8RNeVP3A4_R1OcHJ-DrXgr2HH2UEYrt-Ueu516Gng@mail.gmail.com>
	<CAJTYsWX6b0UxeZ9HGGnju-XpWRmLr_y8AVeyWqd3gL+a0NkGtw@mail.gmail.com>
	<CAHGQGwHnVc97gVZU22zwRQjbhAWQy0Jgm0yrAErgxROSbuAsXg@mail.gmail.com>

Hi,

On Fri, 5 Jun, 2026, 13:28 Fujii Masao, <[email protected]> wrote:

> On Fri, Jun 5, 2026 at 12:42 PM Ayush Tiwari
> <[email protected]> wrote:
> > One small nit: build_buffercache_pages_tupledesc() names attribute 8
> > "usage_count", while the existing pg_buffercache view and the test use
> > "usagecount". This probably does not affect the tupledesc_match() check,
> > but I think it would be better to keep the existing spelling for
> > consistency.
>
> Agreed. I've fixed that and attached an updated version of the patch.
>

LGTM.

Regards,
Ayush

>


view thread (10+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: BUG #19508: pg_buffercache_pages() crashes the backend with an incompatible caller-supplied record definition
  In-Reply-To: <CAJTYsWWqUf2bEAwGfaJvLmokRXBn4yGKVD=jmysnQV9dmv1fwA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox