public inbox for [email protected]  

help / color / mirror / Atom feed

From: Ayush Tiwari <[email protected]>
To: Daniel Gustafsson <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: [email protected]
Subject: Re: to_date()/to_timestamp() silently accept month=0 and day=0
Date: Fri, 24 Apr 2026 18:20:45 +0530
Message-ID: <CAJTYsWXor+vwxEH4oxxjZcQi9bcxz=9OAFt7wQWRxpaA_HyGiQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAJTYsWWNfF+hMpbsTDF8NMr+AuqoDfNxR=oHUZm7xqGP+dJ9rA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAJTYsWUJFHhqiGD+6vw6m0ELqjajoKev2UutFUMB2uQDjm6+TA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAJTYsWV1wEuv2ZbBHt4BQ2O4-Na6JdxSU3b--GFzs-j5cG_pVA@mail.gmail.com>
	<CAJTYsWVEk5vdy8of2DCWzDNJgHUNL0p0Dt6b1zkgmvmNo3ht6w@mail.gmail.com>
	<[email protected]>

On Fri, 24 Apr 2026 at 18:14, Daniel Gustafsson <[email protected]> wrote:

> > On 24 Apr 2026, at 11:13, Ayush Tiwari <[email protected]>
> wrote:
>
> > Attached patch, please review.
>
> LGTM for the most part, I don't really think we need to use both to_date
> and
> to_timestamp though, we can save a few cycles there.  I rewrote the
> comments to
> match the rest of the file, and moved to where to where we test for year
> 0000
> since it seems like a better place.  Also took the liberty to use year 100
> in
> one of the testcase, while the year is superfluous for the test in
> question,
> year 100 was previously untested so this will increase test coverage for
> free.
>

Looks good to me. Thank you!

Regards,
Ayush

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: to_date()/to_timestamp() silently accept month=0 and day=0
  In-Reply-To: <CAJTYsWXor+vwxEH4oxxjZcQi9bcxz=9OAFt7wQWRxpaA_HyGiQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox