public inbox for [email protected]  

help / color / mirror / Atom feed

From: John Naylor <[email protected]>
To: Tom Lane <[email protected]>
Cc: [email protected]
Cc: [email protected]
Subject: Re: BUG #19450: Where is checksum_block.inc.c after master install?
Date: Mon, 6 Apr 2026 09:57:40 +0700
Message-ID: <CANWCAZbbegtd55eA7DwkkSAHPHyh4x-ZR=JyuLr37ZOD56h_8A@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CANWCAZYh-54rBucrL=tJQ5-UzRBUihZfS9wYtz=qUbhmuYJyxQ@mail.gmail.com>
	<[email protected]>

On Mon, Apr 6, 2026 at 9:50 AM Tom Lane <[email protected]> wrote:
> src/include/Makefile knows what it's supposed to install out
> of that subtree, and it thinks storage/*.h is sufficient.
> I didn't check to see if the meson system has the same oversight.
>
> One could argue that the real bug is having put a .c file into
> the include/ tree in the first place.  Why was it done like that?
> Couldn't it be a .h file?

That was the way it was first coded. I thought of this way to avoid
adding an exception to headerscheck. I can reverse that decision
easily, but I may not get to it today.

-- 
John Naylor
Amazon Web Services

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: BUG #19450: Where is checksum_block.inc.c after master install?
  In-Reply-To: <CANWCAZbbegtd55eA7DwkkSAHPHyh4x-ZR=JyuLr37ZOD56h_8A@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox