From: Alex Enachioaie <alex@altmetric.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17327: Postgres server does not correctly emit error for max_slot_wal_keep_size being breached
Date: Tue, 14 Dec 2021 10:03:49 +0000
Message-ID: <DYN34R.FUPBYLP1ZNOA1@altmetric.com> (raw)
In-Reply-To: <20211214.101137.379073733372253470.horikyota.ntt@gmail.com>
References: <Z4PW3R.84TE92O82TFQ@altmetric.com>
<20211213.144442.1533332056665514669.horikyota.ntt@gmail.com>
<FGS14R.K3L8GOS0U6ZQ1@altmetric.com>
<20211214.101137.379073733372253470.horikyota.ntt@gmail.com>
Hello Kyotaro,
Exactly and that sounds like an excellent solution.
Thanks!
Alex Enachioaie
Senior Site Reliability Engineer
Altmetric
On Tue, Dec 14 2021 at 10:11:37 +0900, Kyotaro Horiguchi
<horikyota.ntt@gmail.com> wrote:
> Hello, Alex.
>
> At Mon, 13 Dec 2021 09:45:51 +0000, Alex Enachioaie
> <alex@altmetric.com <mailto:alex@altmetric.com>> wrote in
>> I think I'm happy to leave the method of resolution up to you, I
>> think
>> the main point for me would be that when a
>> replication process gets terminated as a consequence of the
>> underlying
>> temporary replication slot reaching max_slot_wal_keep_size
>> that we log a specific message to indicate to the user the cause of
>> the termination rather than leave it ambiguous.
>
> Ah.. I think I got your point. I thought that the message
> "terminating process to release replication slot X" is showing the
> cause for process termination but actually it doesn't mention the
> reason for releasing replication slot. For persistent slots the
> following message "invalidating slot" does that but that message is
> absent for temporary slots. However, in that sense, the root reason
> is not clearly stated in any case.
>
> So I'm going to propose something like the following.
>
> LOG: terminating process nnnnn to release replication slot "slot"
> + DETAIL: The WAL files retained by the slot is going to exceed
> max_slot_wal_keep_size.
>
> Thanks!
>
> --
> Kyotaro Horiguchi
> NTT Open Source Software Center
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: alex@altmetric.com, horikyota.ntt@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17327: Postgres server does not correctly emit error for max_slot_wal_keep_size being breached
In-Reply-To: <DYN34R.FUPBYLP1ZNOA1@altmetric.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox